Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azcore/policy retry: missing documentation about handling of retry-after header #18638

Closed
serbrech opened this issue Jul 20, 2022 · 1 comment
Assignees
Milestone

Comments

@serbrech
Copy link
Member

serbrech commented Jul 20, 2022

// use the delay from retry-after if available
delay := shared.RetryAfter(resp)
if delay <= 0 {
delay = calcDelay(options, try)
}

I was surprised to see no mention of the handling of retry-after header by the client.
I had to look at the code to find the above code snippet.
This behavior is not documented in the RetryDelay option that can be set on the clients:

// RetryDelay specifies the initial amount of delay to use before retrying an operation.
// The delay increases exponentially with each retry up to the maximum specified by MaxRetryDelay.
// The default value is four seconds. A value less than zero means no delay between retries.
RetryDelay time.Duration

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 20, 2022
@serbrech serbrech changed the title azcore/policy retry: missing documentation of handling of retry-after header azcore/policy retry: missing documentation about handling of retry-after header Jul 20, 2022
@jhendrixMSFT jhendrixMSFT added Docs Azure.Core and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jul 20, 2022
@jhendrixMSFT jhendrixMSFT self-assigned this Jul 20, 2022
ghost pushed a commit that referenced this issue Jul 20, 2022
@jhendrixMSFT
Copy link
Member

Fixes will ship in the August release.

@RickWinter RickWinter added this to the 2022-08 milestone Jul 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants