Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add release stage for scheduled pipelines #17312

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Do not add release stage for scheduled pipelines #17312

merged 1 commit into from
Mar 16, 2022

Conversation

benbp
Copy link
Member

@benbp benbp commented Mar 15, 2022

No description provided.

@benbp benbp requested a review from weshaggard as a code owner March 15, 2022 21:22
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Mar 15, 2022
@benbp benbp self-assigned this Mar 15, 2022
@benbp
Copy link
Member Author

benbp commented Mar 15, 2022

/azp run go - azcore

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp benbp requested a review from seankane-msft March 15, 2022 22:03
RickWinter
RickWinter approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me ;)

@benbp benbp merged commit 5b65f62 into Azure:main Mar 16, 2022
@benbp benbp deleted the benbp/release-on-manual branch March 16, 2022 17:03
@tadelesh
Copy link
Member

@benbp Mgmt plane use release job to auto check whether a new version need to be released. If it is set to manual, we need to trigger almost 200 rps' pipeline manually if we need to do a round of refresh. Is there any workaround of this or I need to separate the logic?

@benbp
Copy link
Member Author

benbp commented Mar 22, 2022

@benbp Ben Broderick Phillips FTE Mgmt plane use release job to auto check whether a new version need to be released. If it is set to manual, we need to trigger almost 200 rps' pipeline manually if we need to do a round of refresh. Is there any workaround of this or I need to separate the logic?

@tadelesh let's discuss using something like an opt-in parameter? Apologies I missed the context here, I should have added you as a reviewer. I'll reach out on chat.

@benbp benbp mentioned this pull request Mar 22, 2022
Closed
@weshaggard weshaggard mentioned this pull request Mar 23, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@seankane-msft seankane-msft seankane-msft approved these changes

@RickWinter RickWinter RickWinter approved these changes

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benbp @tadelesh @RickWinter @weshaggard @seankane-msft