Gen.go update #547
Merged
Gen.go update #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstr
suggested changes
Feb 15, 2017
Gododir/gen.go
Outdated
| @@ -404,14 +414,16 @@ func generate(service *service) { | |||
| fmt.Printf("Generating %s...\n\n", service.Fullname) | |||
| delete(service) | |||
|
|
|||
| autorest := exec.Command(fmt.Sprintf("%s/autorest/src/core/AutoRest/bin/Debug/net451/win7-x64/autorest", autorestDir), | |||
| autorest := exec.Command("gulp", | |||
There was a problem hiding this comment.
Given that this is pretty new stuff, and some of our computers (okay, well mine) haven't had gulp setup yet, we may want to add in some guard rails like this:
exec.LookPath(string)
Gododir/gen.go
Outdated
| "-Input", fmt.Sprintf("%s/azure-rest-api-specs/%s.json", swaggersDir, service.Input), | ||
| "-CodeGenerator", "Go", | ||
| "-Header", "MICROSOFT_APACHE", | ||
| "-Namespace", service.Name, | ||
| "-OutputDirectory", service.Output, | ||
| "-Modeler", "Swagger", | ||
| "-pv", sdkVersion) | ||
| autorest.Dir = fmt.Sprintf("%s/autorest", autorestDir) |
There was a problem hiding this comment.
We're all cross-platform like now! How about we update it to:
autorest.Dir = filepath.Join(autores.Dir, "autorest")
Gododir/gen.go
Outdated
| } | ||
|
|
||
| autorest := exec.Command("gulp", | ||
| "autorest", | ||
| "-Input", fmt.Sprintf("%s/azure-rest-api-specs/%s.json", swaggersDir, service.Input), |
There was a problem hiding this comment.
Another candidate for filepath.Join.
There was a problem hiding this comment.
Fixed (and used filepath.Join in some other places too)
marstr
approved these changes
Feb 15, 2017
|
Wait, it is not working as I expected yet :I |
|
It works! |
marstr
pushed a commit
to marstr/azure-sdk-for-go
that referenced
this pull request
Mar 9, 2017
* Updated Gen.go to use new autorest builld system * Comments from review * It works as expected again
marstr
added a commit
that referenced
this pull request
Mar 31, 2017
* Running latest Go Generator on all released packages. * Gen.go update (#547) * Updated Gen.go to use new autorest builld system * Comments from review * It works as expected again * Moving Storage to an Independent Repository (#556) * Updating CI to use Go 1.8. Go 1.8 was released on Thursday, February 16th. Many of our partners have adopted and we need to ensure that we support the most recent version. * Replacing storage folder with submodule. In order to allow for more independent growth of the storage package, we've given it its own repository. This change updates the main repository to use a submodule in order to prevent breaking changes for folks using storage today who do not want to migrate to the new repository. * Updating submodule target URL. There is an existing naming convention for Azure Storage repositories. the repo has been updated to match that convention, this updates the submodule to point to the new URL. * Responding to review feedback. * Updating submodule to ref v8.1.0 storage version. * Fixing issues found while reviewing PR. * Regenerating using latest swaggers. Using Azure/azure-rest-api-specs commit: 7d9b6c0 * Regenerating with new API Version strategy & web composite. The new API Version strategy associated the API Version to send across the wire with each method instead of at the client level. Doing so allows us to support a broader range of composite swaggers (the immediate example is the web composite swagger.) It also means that making a call with an alternate API version is somewhat more difficult in this version. To do so, one would have to create their own Preparer for the request. In the future, we'll support multiple API Versions and allow for more stability by generating independent packages for each Operation Group in each API Version. We expect to have that done in the summer. * Regenerating against most recent swaggers. * Regenerating using latest preview version of compute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works with the cowboy's latest changes.
PTAL @marstr @jhendrixMSFT