Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Storage to an Independent Repository #556

Merged
merged 5 commits into from
Mar 3, 2017
Merged

Moving Storage to an Independent Repository #556

merged 5 commits into from
Mar 3, 2017

Conversation

marstr
Copy link
Member

@marstr marstr commented Feb 22, 2017

Go 1.8 was released on Thursday, February 16th. Many of our partners
have adopted and we need to ensure that we support the most recent
version.

@marstr marstr self-assigned this Feb 22, 2017
@marstr marstr changed the title Updating CI to use Go 1.8. Moving Storage to an Independent Repository Feb 23, 2017
@@ -0,0 +1,3 @@
[submodule "storage"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get rid of funcs related to storage in gen.go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes :) I'll get on that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -2,7 +2,7 @@ sudo: false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to get rid of some lines here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Go 1.8 was released on Thursday, February 16th. Many of our partners
have adopted and we need to ensure that we support the most recent
version.
In order to allow for more independent growth of the storage package,
we've given it its own repository. This change updates the main
repository to use a submodule in order to prevent breaking changes for
folks using storage today who do not want to migrate to the new
repository.
There is an existing naming convention for Azure Storage repositories.
the repo has been updated to match that convention, this updates the
submodule to point to the new URL.
@marstr
Copy link
Member Author

marstr commented Feb 24, 2017

Hey @kpfaulkner, I wanted to give you a heads up about this PR and the new repository. If you have a little time, I'd love for you to do a once-over on Azure/azure-storage-go to ensure that there isn't something critical that we're missing.

@kpfaulkner
Copy link
Contributor

kpfaulkner commented Feb 24, 2017 via email

@marstr marstr added this to the v9.0.0-beta-20170228 milestone Mar 2, 2017
@kpfaulkner
Copy link
Contributor

Definitely thumbs up from me.
Have ported one of my Azure/Go projects to azure-storage-go with minimal hassles. Admittedly most of the porting was due to that I hadn't upgraded that particular project since the whole storage split to separate structs/files for containers/blobs etc.

I like the idea of having all the storage functionality separate to the whole management side of things.

@kpfaulkner
Copy link
Contributor

Any idea when azure-storage-go would become the official storage repo and the storage dir in azure-sdk-for-go would be deprecated?

Or it's still early stages?

@marstr
Copy link
Member Author

marstr commented Mar 3, 2017

Hey Ken, we're targeting Version 9.0 in this repository (so end of the month.) I've been holding out on pulling in this request until closer to when we plan on releasing this change because there is a little chaffing with sub-modules when you switch between branches that have them and don't. However, it may be time to just pull the trigger. It should make clear to folks sending PRs and filing issues that this repo is moved.

.gitmodules Outdated
@@ -1,3 +1,4 @@
[submodule "storage"]
path = storage
url = https://github.com/Azure/azure-storage-go
branch = v0.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is branch correct? Cannot glide take tags?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, lol, this is not glide. But still, the question is the same! Cannot it be tag instead of branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name branch is misleading here. See this thread:
http://stackoverflow.com/questions/19986075/git-submodule-to-track-remote-branch

Alternatively, try cloning my fork to ensure it works :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcardosos and I just tinkered with this offline and can confirm go get has the correct behavior.

@marstr marstr merged commit ce3ce79 into Azure:dev Mar 3, 2017
marstr added a commit to marstr/azure-sdk-for-go that referenced this pull request Mar 9, 2017
* Updating CI to use Go 1.8.

Go 1.8 was released on Thursday, February 16th. Many of our partners
have adopted and we need to ensure that we support the most recent
version.

* Replacing storage folder with submodule.

In order to allow for more independent growth of the storage package,
we've given it its own repository. This change updates the main
repository to use a submodule in order to prevent breaking changes for
folks using storage today who do not want to migrate to the new
repository.

* Updating submodule target URL.

There is an existing naming convention for Azure Storage repositories.
the repo has been updated to match that convention, this updates the
submodule to point to the new URL.

* Responding to review feedback.

* Updating submodule to ref v8.1.0 storage version.
marstr added a commit that referenced this pull request Mar 31, 2017
* Running latest Go Generator on all released packages.

* Gen.go update (#547)

* Updated Gen.go to use new autorest builld system

* Comments from review

* It works as expected again

* Moving Storage to an Independent Repository (#556)

* Updating CI to use Go 1.8.

Go 1.8 was released on Thursday, February 16th. Many of our partners
have adopted and we need to ensure that we support the most recent
version.

* Replacing storage folder with submodule.

In order to allow for more independent growth of the storage package,
we've given it its own repository. This change updates the main
repository to use a submodule in order to prevent breaking changes for
folks using storage today who do not want to migrate to the new
repository.

* Updating submodule target URL.

There is an existing naming convention for Azure Storage repositories.
the repo has been updated to match that convention, this updates the
submodule to point to the new URL.

* Responding to review feedback.

* Updating submodule to ref v8.1.0 storage version.

* Fixing issues found while reviewing PR.

* Regenerating using latest swaggers.

Using Azure/azure-rest-api-specs commit: 7d9b6c0

* Regenerating with new API Version strategy & web composite.

The new API Version strategy associated the API Version to send across the wire with each method instead of at the client level. Doing so allows us to support a broader range of composite swaggers (the immediate example is the web composite swagger.)

It also means that making a call with an alternate API version is somewhat more difficult in this version. To do so, one would have to create their own Preparer for the request. In the future, we'll support multiple API Versions and allow for more stability by generating independent packages for each Operation Group in each API Version. We expect to have that done in the summer.

* Regenerating against most recent swaggers.

* Regenerating using latest preview version of compute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants