Queuesas #657
Queuesas #657
Conversation
|
Hello @kpfaulkner ! |
storage/queuesasuri.go
Outdated
| signedExpiry := expiry.UTC().Format(time.RFC3339) | ||
|
|
||
| // Cannot get this working yet. Any values entered generates bad URL. | ||
| protocols := "" |
There was a problem hiding this comment.
When does this generate a bad URL? I played a little with the protocols option but I did not find problems. Is there something I missed?
There was a problem hiding this comment.
whenever I had a value for "protocols" it wouldn't work. Empty string would be the only value I could get working. You're not seeing that?
There was a problem hiding this comment.
I'll try and repro later today. But whenever I had a value I'd never get it to generate a URL successfully.
There was a problem hiding this comment.
For example if protocol is populated with "https" I generate the SAS URL but when trying to use it I get the error:
AuthenticationFailed
Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:0e3aae9d-0003-002f-3e81-ec31f4000000 Time:2017-06-24T00:31:37.0443316Z
Signature did not match. String to sign used was p 2017-06-24T01:31:26Z /queue/kenfau/temp 2016-05-31
But protocol of an empty string is fine.
There was a problem hiding this comment.
Updated PR to follow similar lines to @mcardosos BlobSAS changes.... although I still cannot get protocol to work properly.
There was a problem hiding this comment.
Hmmm, so the protocol should be included both in the string to sign and on the query. Curious question, when trying to use the SAS URI, are you sending the request with an authorization header?
There was a problem hiding this comment.
My string to sign looks like this...
raup
2050-12-20T21:55:06Z
/queue/golangrocksonazure/name
https,http
2016-05-31
And if I do (manually) a Get queue metadata operation, the URL looks like this
https://golangrocksonazure.queue.core.windows.net/name?comp=metadata&se=2050-12-20T21%3A55%3A06Z&sig=nGP%2BOUcNIc5i%2Fcb1sFD2Ksnpz1CHazjdVy2ewurTUsE%3D&sp=raup&spr=https%2Chttp&sv=2016-05-31
When I get the same error as you is when I don't include the protocols in the URL as query parameters.
There was a problem hiding this comment.
Ahh ok, my bad, I wasn't including them as a parameter as well.
|
Merged #662 :D |
|
Everything looking good now. |
storage/queuesasuri.go
Outdated
| } | ||
|
|
||
| // assumption that start time is now. | ||
| signedStart := "" |
There was a problem hiding this comment.
This assumption is done by Azure, not the SDK. I would prefer this comment to go away.
storage/queuesasuri.go
Outdated
| return sasURL.String(), nil | ||
| } | ||
|
|
||
| func queueSASStringToSign(signedVersion, canonicalizedResource, signedStart, signedExpiry, signedIP string, signedPermissions string, protocols string, signedIdentifier string) (string, error) { |
There was a problem hiding this comment.
string [](start = 100, length = 6)
Nit, "string" is not needed by all parameters here.
|
@kpfaulkner Cool! just some last tiny comments, but other than that, LGTM :D |
|
Awesome! @kpfaulkner |
Generating SAS URLs for Storage queues. Similar approach to the blob SAS generation.
Related issue #656
One problem I haven't been able to resolve is that if I'm reading the specs ( https://docs.microsoft.com/en-us/rest/api/storageservices/constructing-a-service-sas ) correctly I should be able to specify the protocol to use (http and/or https). Currently I cannot get that working, but leaving it as blank IS accepted by the spec (and works).