GetSASURI is more complete and has grouped params #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetSASURI also includes signed identifier and overridable headers Got rid of GetSASURIWithSignedIPAndProtocol
This was referenced Jun 22, 2017
Merged
| func (c *Container) GetSASURIWithSignedIPAndProtocol(expiry time.Time, permissions string, signedIPRange string, HTTPSOnly bool) (string, error) { | ||
| // ContainerSASPermissions includes the available permissions for | ||
| // a container SAS URI. | ||
| type ContainerSASPermissions struct { |
There was a problem hiding this comment.
Seems like this could be a superset of BlobSASPermissions (or perhaps some other "base" type) to avoid duplication.
storage/container.go
Outdated
| return c.bsc.client.commonSASURI(expiry, uri, permissions, signedIPRange, canonicalizedResource, signedResource, HTTPSOnly) | ||
|
|
||
| // build permissions string | ||
| permissions := "" |
There was a problem hiding this comment.
Move this logic into a base type and make it a method so you don't have to repeat it.
kpfaulkner
reviewed
Jun 23, 2017
storage/blobsasuri.go
Outdated
| SASOptions | ||
| } | ||
|
|
||
| // SASOptions includes options used by SAS URIs for diffrenet |
kpfaulkner
reviewed
Jun 23, 2017
storage/blobsasuri.go
Outdated
| } | ||
|
|
||
| func (c *Client) commonSASURI(expiry time.Time, uri, permissions, signedIPRange, canonicalizedResource, signedResource string, HTTPSOnly bool) (string, error) { | ||
| func (c *Client) commonSASURI(options SASOptions, uri, permissions, canonicalizedResource, signedResource string, headers OverrideHeaders) (string, error) { |
There was a problem hiding this comment.
commonSASURI isn't really completely common. It's valid to use for blob and fileservice but not tables or queues (unless we add a few conditionals in there). Maybe rename it to reflect blob/fileservice usage only?
| // See https://msdn.microsoft.com/en-us/library/azure/ee395415.aspx | ||
| func (b *Blob) GetSASURIWithSignedIPAndProtocol(expiry time.Time, permissions string, signedIPRange string, HTTPSOnly bool) (string, error) { | ||
| // See https://docs.microsoft.com/en-us/rest/api/storageservices/constructing-a-service-sas | ||
| func (b *Blob) GetSASURI(options BlobSASOptions) (string, error) { |
There was a problem hiding this comment.
Be sure to document this breaking change in the change log.
jhendrixMSFT
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetSASURI func now receive grouped parameters
GetSASURI also includes signed identifier and overridable headers
Got rid of GetSASURIWithSignedIPAndProtocol
PTAL
@marstr @jhendrixMSFT