Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] EventHub AMQP Token refresh recovery #18343

Closed
kacheng2018 opened this issue Dec 24, 2020 · 1 comment
Closed

[FEATURE REQ] EventHub AMQP Token refresh recovery #18343

kacheng2018 opened this issue Dec 24, 2020 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs feature-request This issue requires a new behavior in the product in order be resolved. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@kacheng2018
Copy link

To follow-up on the problem the customer encountered (github issue: #17810), the client token credential failed in class com.azure.core.amqp.implementation.ActiveClientTokenManager. As the credential is inheritedly managed by SDK, the SDK should provide a mechanism to help recovering the failure by catching the exception and renew/refresh the required token.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 24, 2020
@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Event Hubs feature-request This issue requires a new behavior in the product in order be resolved. labels Dec 28, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 28, 2020
@conniey
Copy link
Member

conniey commented Feb 20, 2021

We have logic to retry an exception when it is retriable. The error message in the stack is:

Error occurred while refreshing token that is not retriable.

The non-retriable error being that the ReactorConnection is closed. It's fruitless to retry on a closed connection. The connection has to be reopened. The EventProcessorClient should be reopening the connection when it is closed.

@conniey conniey closed this as completed Feb 20, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this issue Mar 25, 2022
@xwang971 @erich-wang
@Juliehzl @michaelkira @vturecek
CodeGen from PR 18356 in Azure/azure-rest-api-specs
9ecba73 
Adding Microsoft.App stable version 2022-03-01 (Azure#18356)

* Adds base for updating Microsoft.App from version preview/2022-01-01-preview to version 2022-03-01

* Updates readme

* Updates API version in new specs and examples

* refactore properties (Azure#18137)

* [Non Break Change]Update to use easy auth v2 same as Web App (Azure#18143) (Azure#18217)

* Update auth config to use the same auth config in App Service

* Update for spell check

* Remove TokenStore/ConfigFilePath as not supported for ContainerApp

* Copy AuthConfig from previous version (Azure#18221)

* Copy updated AuthConfig from previous version

* Add suppression

* Add API for checkNameAvailability in 2022-03-01 (Azure#18204)

* add API

* update

* fix

* update

* update

* Add label property (Azure#18280)

* Add label property

* fix prettier

Co-authored-by: Juliehzl <zuh@microsoft.com>

* refactor sc properties in 03-01 (Azure#18343)

* refactor sc properties in 03-01

* Revert "refactore properties (Azure#18137)"

This reverts commit 4fe86bce74ae6a3566388d0a1037cb35be8a23e7.

* add odata query (Azure#18364)

* Updating patch spec. (Azure#18354)

* Updating patch spec.

* Fix linter

* prettier fix

* Adding x-ms-long-running-operation

Co-authored-by: Ruslan Yakushev 🚴 <1664475+ruslany@users.noreply.github.com>

Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
Co-authored-by: erich-wang <eriwan@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs feature-request This issue requires a new behavior in the product in order be resolved. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@conniey @kacheng2018 @alzimmermsft