Support conditional access policy in obo flow. #18354

han-gao · 2020-12-25T02:29:14Z

Fix AzureOAuthenticationFailureHandler not display error info in web page.
Support conditional access policy in this flow: webapp -> webapi(obo) -> other-webapi

chenrujun · 2020-12-28T01:01:01Z

Hi, @han-gao , you can push to this branch forced to continue your task.

chenrujun · 2020-12-28T01:26:54Z

@han-gao , Rename AzureOAuthenticationFailureHandler to AADOAuthenticationFailureHandler.

…to fix_not_error_info # Conflicts: # sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADAuthenticationFailureHandler.java

…to fix_not_error_info

sdk/spring/azure-spring-boot/pom.xml

...g-boot/src/main/java/com/azure/spring/aad/webapi/AADOAuth2OboAuthorizedClientRepository.java

...ring/azure-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebAppConfiguration.java

...e-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebSecurityConfigurerAdapter.java

sdk/spring/azure-spring-boot-starter-active-directory/pom.xml

sdk/spring/azure-spring-boot/pom.xml

.../azure-spring-boot/src/main/java/com/azure/spring/aad/webapp/ConditionalAccessException.java

...g-boot/src/main/java/com/azure/spring/aad/webapi/AADOAuth2OboAuthorizedClientRepository.java

...ring/azure-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebAppConfiguration.java

…to fix_not_error_info

chenrujun · 2021-02-09T23:37:09Z

Hi, @han-gao , please merge latest master branch to your feature branch.

…to fix_not_error_info # Conflicts: # sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebSecurityConfigurerAdapter.java

...-samples/azure-spring-boot-sample-active-directory-webapp/src/main/resources/application.yml

...g-boot/src/main/java/com/azure/spring/aad/webapi/AADOAuth2OboAuthorizedClientRepository.java

...-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADHandleConditionalAccessFilter.java

...ring/azure-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebAppConfiguration.java

...e-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebSecurityConfigurerAdapter.java

…to fix_not_error_info # Conflicts: # sdk/spring/azure-spring-boot-samples/azure-spring-boot-sample-active-directory-webapp/src/main/resources/application.yml # sdk/spring/azure-spring-boot/pom.xml

…to fix_not_error_info

sdk/spring/azure-spring-boot/pom.xml

...e-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebSecurityConfigurerAdapter.java

...g-boot/src/main/java/com/azure/spring/aad/webapi/AADOAuth2OboAuthorizedClientRepository.java

...e-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebSecurityConfigurerAdapter.java

chenrujun · 2021-02-23T00:27:16Z

...e-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebSecurityConfigurerAdapter.java

@@ -51,7 +50,8 @@ protected void configure(HttpSecurity http) throws Exception {
                .and()
            .logout()
                .logoutSuccessHandler(oidcLogoutSuccessHandler())
-                .and();
+                .and()
+            .addFilterBefore(new AADHandleConditionalAccessFilter(), ExceptionTranslationFilter.class);


By doing this, do you mean ExceptionTranslationFilter will always exist in context?

Yes, this filter handles most authorization failures and always loaded into the filterchain.

chenrujun

Add comments in java code about how conditional access work.
Add content in readme about how to use conditional access.

You can do these after you finished adding integration test.

chenrujun · 2021-02-23T00:29:46Z

/azp run java - spring - tests

azure-pipelines · 2021-02-23T00:29:57Z

Azure Pipelines successfully started running 1 pipeline(s).

chenrujun · 2021-02-23T23:25:35Z

Hi, @han-gao , please merge latest master branch to your feature branch.

…to fix_not_error_info

chenrujun · 2021-02-26T03:13:31Z

/azp run java - spring - tests

azure-pipelines · 2021-02-26T03:13:48Z

Azure Pipelines successfully started running 1 pipeline(s).

Adding Microsoft.App stable version 2022-03-01 (Azure#18356) * Adds base for updating Microsoft.App from version preview/2022-01-01-preview to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * refactore properties (Azure#18137) * [Non Break Change]Update to use easy auth v2 same as Web App (Azure#18143) (Azure#18217) * Update auth config to use the same auth config in App Service * Update for spell check * Remove TokenStore/ConfigFilePath as not supported for ContainerApp * Copy AuthConfig from previous version (Azure#18221) * Copy updated AuthConfig from previous version * Add suppression * Add API for checkNameAvailability in 2022-03-01 (Azure#18204) * add API * update * fix * update * update * Add label property (Azure#18280) * Add label property * fix prettier Co-authored-by: Juliehzl <zuh@microsoft.com> * refactor sc properties in 03-01 (Azure#18343) * refactor sc properties in 03-01 * Revert "refactore properties (Azure#18137)" This reverts commit 4fe86bce74ae6a3566388d0a1037cb35be8a23e7. * add odata query (Azure#18364) * Updating patch spec. (Azure#18354) * Updating patch spec. * Fix linter * prettier fix * Adding x-ms-long-running-operation Co-authored-by: Ruslan Yakushev 🚴 <1664475+ruslany@users.noreply.github.com> Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com> Co-authored-by: erich-wang <eriwan@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>

fix failureHandle not error info

b18f250

han-gao requested review from backwind1233, chenrujun, jialindai, saragluna and yiliuTo as code owners December 25, 2020 02:29

ghost added the azure-spring All azure-spring related issues label Dec 25, 2020

han-gao closed this Dec 25, 2020

chenrujun reopened this Dec 28, 2020

chenrujun changed the title ~~fix failureHandle not error info~~ AzureOAuthenticationFailureHandler will not display error info in web page. Dec 28, 2020

fix failureHandle not error info

0254e88

saragluna added the azure-spring-aad Spring active directory related issues. label Jan 7, 2021

v-gaoh added 5 commits January 11, 2021 09:50

Merge branch 'master' of git://github.com/Azure/azure-sdk-for-java in…

b2b72f7

…to fix_not_error_info # Conflicts: # sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADAuthenticationFailureHandler.java

Merge branch 'master' of git://github.com/Azure/azure-sdk-for-java in…

72654ff

…to fix_not_error_info

fix failureHandle not error info

230ca9d

code format for checkStyle

726a95e

code format for checkStyle

33ac445

chenrujun suggested changes Jan 12, 2021

View reviewed changes

v-gaoh added 2 commits January 12, 2021 17:40

add webClient handle conditional access policy.

76b9b15

add dependency to azure-spring-boot-starter-active-directory-pom

24a7bfd

han-gao requested review from alzimmermsft, danieljurek, JimSuplizio, mitchdenny and samvaity as code owners January 13, 2021 06:00

v-gaoh added 2 commits January 13, 2021 14:01

add webflux to external_dependency.

6f3250c

Modify note.

6942393

chenrujun suggested changes Jan 13, 2021

View reviewed changes

v-gaoh added 6 commits February 2, 2021 14:43

resolve conflicts.

7f1945c

Merge branch 'master' of git://github.com/Azure/azure-sdk-for-java in…

fc4da85

…to fix_not_error_info

update ConditionalAccessException.java

162d5ac

fix code style.

f103bad

when re-authentication, update all clients.

47daa01

remove ConditionalAccessException.java

2396408

v-gaoh added 4 commits February 10, 2021 09:34

Merge branch 'master' of git://github.com/Azure/azure-sdk-for-java in…

809661d

…to fix_not_error_info # Conflicts: # sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADWebSecurityConfigurerAdapter.java

resolve conflicts.

bd0c5cd

Solve pipeline problems.

9da07e2

Solve pipeline problems.

6ff1f95

chenrujun self-assigned this Feb 19, 2021

chenrujun suggested changes Feb 19, 2021

View reviewed changes

v-gaoh added 4 commits February 20, 2021 18:10

resolve conversation.

707c22d

Merge branch 'master' of git://github.com/Azure/azure-sdk-for-java in…

6aade06

…to fix_not_error_info # Conflicts: # sdk/spring/azure-spring-boot-samples/azure-spring-boot-sample-active-directory-webapp/src/main/resources/application.yml # sdk/spring/azure-spring-boot/pom.xml

Merge branch 'master' of git://github.com/Azure/azure-sdk-for-java in…

3b7bf5a

…to fix_not_error_info

add web-flux dependency to aad stater

d2259e8

chenrujun suggested changes Feb 22, 2021

View reviewed changes

v-gaoh added 2 commits February 22, 2021 14:25

add web-flux dependency to aad stater

ab6be45

resolve conversation.

bfb52b5

chenrujun reviewed Feb 23, 2021

View reviewed changes

chenrujun approved these changes Feb 23, 2021

View reviewed changes

Merge branch 'master' of git://github.com/Azure/azure-sdk-for-java in…

713d0db

…to fix_not_error_info

chenrujun merged commit 6e7e9fb into Azure:master Feb 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support conditional access policy in obo flow. #18354

Support conditional access policy in obo flow. #18354

han-gao commented Dec 25, 2020 •

edited by chenrujun

Loading

chenrujun commented Dec 28, 2020

chenrujun commented Dec 28, 2020

chenrujun commented Feb 9, 2021

chenrujun Feb 23, 2021

han-gao Feb 23, 2021

chenrujun left a comment

chenrujun commented Feb 23, 2021

azure-pipelines bot commented Feb 23, 2021

chenrujun commented Feb 23, 2021

chenrujun commented Feb 26, 2021

azure-pipelines bot commented Feb 26, 2021

Support conditional access policy in obo flow. #18354

Support conditional access policy in obo flow. #18354

Conversation

han-gao commented Dec 25, 2020 • edited by chenrujun Loading

chenrujun commented Dec 28, 2020

chenrujun commented Dec 28, 2020

chenrujun commented Feb 9, 2021

chenrujun Feb 23, 2021

Choose a reason for hiding this comment

han-gao Feb 23, 2021

Choose a reason for hiding this comment

chenrujun left a comment

Choose a reason for hiding this comment

chenrujun commented Feb 23, 2021

azure-pipelines bot commented Feb 23, 2021

chenrujun commented Feb 23, 2021

chenrujun commented Feb 26, 2021

azure-pipelines bot commented Feb 26, 2021

han-gao commented Dec 25, 2020 •

edited by chenrujun

Loading