Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realize azure credential chain to simplify and unify developer credential management experience across spring libraries. #21472

Closed
z1069867141 opened this issue May 14, 2021 · 1 comment · Fixed by #23849
Closed

Realize azure credential chain to simplify and unify developer credential management experience across spring libraries. #21472

z1069867141 opened this issue May 14, 2021 · 1 comment · Fixed by #23849
Assignees
@saragluna
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
[2021] October

Comments

@z1069867141
Copy link

z1069867141 commented May 14, 2021 •
edited by saragluna
Loading

https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/spring/azure-identity-spring

To provide a unified way for Spring users to provide their credentials to authenticate with AAD. Each starter should share the same configuration fields, which will be used to auto-wire a credential, while each service could specify a service dedicated credential:

spring.cloud.azure:
  credential:
    client-id:
    client-secret:
    client-certificate-path:
    authority-host:
  servicebus:
    credential:
      client-id:
      client-secret:
      client-certificate-path:
      authority-host:

However, each service has authentication methods that only apply to themselves, check this wiki https://github.com/Azure/azure-sdk-for-java/wiki/Spring:-Unify-Azure-Credentials-construction-in-Azure-Spring.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 14, 2021
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label May 14, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 14, 2021
@backwind1233 backwind1233 added Client This issue points to a problem in the data-plane of the library. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 14, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 14, 2021
@backwind1233 backwind1233 added feature-request This issue requires a new behavior in the product in order be resolved. and removed customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 14, 2021
@chenrujun chenrujun added this to the Backlog milestone May 17, 2021
@saragluna saragluna changed the title Enhance unified Spring Identity Library Realize azure credential chain to simplify and unify developer credential management experience across spring libraries. Jun 1, 2021
@saragluna saragluna mentioned this issue Jun 1, 2021
Closed
3 tasks
@saragluna saragluna modified the milestones: Backlog, [2021] July Jun 1, 2021
@saragluna saragluna assigned saragluna and unassigned chenrujun Jun 1, 2021
@saragluna saragluna modified the milestones: [2021] July, [2021] August Jun 30, 2021
@saragluna saragluna mentioned this issue Jul 1, 2021
Closed
17 tasks
This was referenced Aug 5, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@saragluna saragluna mentioned this issue Aug 5, 2021
Closed
@saragluna saragluna mentioned this issue Aug 5, 2021
Closed
@saragluna saragluna removed their assignment Aug 5, 2021
@saragluna saragluna linked a pull request Aug 31, 2021 that will close this issue
Add Spring Boot auto-configuration of all Azure Spring supported SDK clients #23849
Merged
10 tasks
@saragluna saragluna assigned saragluna and unassigned moarychan Sep 2, 2021
@saragluna
Copy link
Member

Closing this now for it's been merged to 4.0 branch.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Dec 8, 2022
@p-bouchon @ruslany
@zhenqxuMSFT @najian
CodeGen from PR 21683 in Azure/azure-rest-api-specs
d9fbd78 
Release app microsoft.app 2022 10 01 (Azure#21683)

* Adds base for updating Microsoft.App from version preview/2022-06-01-preview to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AppState and LatestReadyRevisionName (Azure#21034)

* Add new props

* add defaults

* Add swagger for client cert & CORS policy (Azure#21126)

* Fix password format of env domain for 2022-10-01 (Azure#21463)

* fix

* fix

* Remove AppState property as we decided to postpone it (Azure#21483)

* Remove AppState property as we decided to postpone it

* Fix swagger issues

* More swagger fixes

* s360 swagger correctness fixes (Azure#21472)

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Add kind for managed environment (Azure#21589)

* add

* fix

* fix (Azure#21730)

* fix (Azure#21747)

Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saragluna saragluna

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
[2021] October
5 participants
@backwind1233 @chenrujun @moarychan @saragluna @z1069867141