Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] The SDK Event Hubs service client builder can not use a custom TraceProvider #24086

Closed
2 tasks done
moarychan opened this issue Sep 13, 2021 · 3 comments · Fixed by #32573 or #33600
Closed
2 tasks done
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@moarychan
Copy link
Member

Is your feature request related to a problem? Please describe.
Azure SDKEvent Hubs builder can not use a custom TraceProvider, the trace provider usage in client builder is here, EventProcessorClientBuilder, EventHubClientBuilder. The new trace implementation of azure core tracer interface will use the same Spring Sleuth tracer from Spring Application Context, or else the tracer information will not be linked for the same request which comes from Spring MVC and finally call Azure SDK methods.

Describe the solution you'd like
When building a service client, it's available to set a custom TraceProvider for EventHubClientBuilder and EventProcessorClientBuilder instance.

Describe alternatives you've considered
No better solutions to achieve this feature.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 13, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 13, 2021
@saragluna saragluna added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Sep 14, 2021
@saragluna
Copy link
Member

@joshfree, do you know whom I could assign this issue to?

@saragluna
Copy link
Member

Hi @lmolkova, could you help provide some samples on how to set the TraceProvider to Event Hubs client builder after #32573, where I see how to set the TraceProvider to HttpPipeline.

@lmolkova lmolkova reopened this Jan 19, 2023
@lmolkova
Copy link
Member

I'll need to update EventHubs and ServiceBus first, after core is released next month. For OpenTelemetry it will be done in the following way: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core-tracing-opentelemetry-samples/src/samples/java/com/azure/core/tracing/opentelemetry/samples/TracingJavaDocCodeSnippets.java#L59

If you're keeping alternative tracing implementations, you can extend TracingOptions in a similar way to how it's done in azure-core-tracing-opentelemetry package.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue May 24, 2023
Modify ipv6 firewall rules swagger file of 2022-11-01 (Azure#24086)

* modify ipv6 firewall rules swagger of 2022-11-01

* Update V5 tag
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
4 participants