Updated netty versions to 4.1.50.Final #11271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagraThapar
requested review from
danieljurek,
JimSuplizio,
mitchdenny,
moderakh and
weshaggard
as code owners
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
suggested changes
May 19, 2020
sdk/cosmos/tests.yml
Outdated
| # by running them against a different cosmosdb instance | ||
| - template: ../../eng/pipelines/templates/jobs/archetype-sdk-tests.yml | ||
| parameters: | ||
| TestName: Single_Region_Session_2 |
There was a problem hiding this comment.
you seem to be removing our integration tests. are the tests not working for v3?
There was a problem hiding this comment.
They are:
- just clubbed some of different CIs to single CI with both Https and Tcp protocol.
- removed some of the extra ones which we don't need every single time for every change.
- In addition, we really don't need all these CIs for v3 as there is no feature changes going on.
I am okay with adding them back if you think they are essential.
moderakh
reviewed
May 19, 2020
| @@ -22,7 +22,6 @@ jobs: | |||
| DisplayName: ReadMyWrites Integration Tests | |||
| OSVmImage: 'ubuntu-18.04' | |||
| ProfileFlag: '-Pe2e' | |||
| AdditionalArgs: '-DargLine="-Dcosmos.directModeProtocol=Https"' | |||
There was a problem hiding this comment.
why these ones are removed? is that intentional?
There was a problem hiding this comment.
Yes, currently on V3- we are not running e2e tests on Tcp mode, which is important as compared to running e2e tests on https mode.
| @@ -190,7 +189,6 @@ jobs: | |||
| DisplayName: Single Region ReadMyWrites | |||
| OSVmImage: 'ubuntu-18.04' | |||
| ProfileFlag: '-Pe2e' | |||
| AdditionalArgs: '-DargLine="-Dcosmos.directModeProtocol=Https"' | |||
There was a problem hiding this comment.
Yes, currently on V3- we are not running e2e tests on Tcp mode, which is important as compared to running e2e tests on https mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulnerabilities Reported:
https://vuln.whitesourcesoftware.com/vulnerability/CVE-2020-11612/
https://vuln.whitesourcesoftware.com/vulnerability/CVE-2019-20445/
https://vuln.whitesourcesoftware.com/vulnerability/CVE-2019-20444/