Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated netty versions to 4.1.50.Final #11271

Merged
merged 3 commits into from
May 19, 2020
Merged

Updated netty versions to 4.1.50.Final #11271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1605a0b
Updated netty versions to 4.1.50.Final
kushagraThapar May 19, 2020
7860484
Updated tests.yml for v3 brannch
kushagraThapar May 19, 2020
b404a71
Reverted CI changes
kushagraThapar May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eng/versioning/external_dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ cosmos_com.google.guava:guava;25.0-jre
cosmos_io.dropwizard.metrics:metrics-core;4.1.0
cosmos_io.dropwizard.metrics:metrics-jvm;4.1.0
cosmos_io.dropwizard.metrics:metrics-graphite;4.1.0
cosmos_io.netty:netty-codec-http;4.1.50.Final
cosmos_io.netty:netty-handler;4.1.50.Final
cosmos_io.projectreactor.netty:reactor-netty;0.9.7.RELEASE
cosmos_io.projectreactor:reactor-core;3.3.5.RELEASE

# sdk\eventgrid\microsoft-azure-eventgrid\pom.xml
eventgrid_com.microsoft.azure:azure-client-runtime;1.5.0
Expand Down
8 changes: 4 additions & 4 deletions sdk/cosmos/microsoft-azure-cosmos/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,19 +69,19 @@ Licensed under the MIT License.
<dependency>
<groupId>io.projectreactor</groupId>
<artifactId>reactor-core</artifactId>
<version>3.3.0.RELEASE</version> <!-- {x-version-update;io.projectreactor:reactor-core;external_dependency} -->
<version>3.3.5.RELEASE</version> <!-- {x-version-update;cosmos_io.projectreactor:reactor-core;external_dependency} -->
</dependency>

<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-codec-http</artifactId>
<version>4.1.44.Final</version> <!-- {x-version-update;io.netty:netty-codec-http;external_dependency} -->
<version>4.1.50.Final</version> <!-- {x-version-update;cosmos_io.netty:netty-codec-http;external_dependency} -->
</dependency>

<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-handler</artifactId>
<version>4.1.44.Final</version> <!-- {x-version-update;io.netty:netty-handler;external_dependency} -->
<version>4.1.50.Final</version> <!-- {x-version-update;cosmos_io.netty:netty-handler;external_dependency} -->
</dependency>

<dependency>
Expand Down Expand Up @@ -177,7 +177,7 @@ Licensed under the MIT License.
<dependency>
<groupId>io.projectreactor.netty</groupId>
<artifactId>reactor-netty</artifactId>
<version>0.9.4.RELEASE</version> <!-- {x-version-update;io.projectreactor.netty:reactor-netty;external_dependency} -->
<version>0.9.7.RELEASE</version> <!-- {x-version-update;cosmos_io.projectreactor.netty:reactor-netty;external_dependency} -->
</dependency>

<dependency>
Expand Down
2 changes: 0 additions & 2 deletions sdk/cosmos/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
DisplayName: ReadMyWrites Integration Tests
OSVmImage: 'ubuntu-18.04'
ProfileFlag: '-Pe2e'
AdditionalArgs: '-DargLine="-Dcosmos.directModeProtocol=Https"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these ones are removed? is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, currently on V3- we are not running e2e tests on Tcp mode, which is important as compared to running e2e tests on https mode.

DESIRED_CONSISTENCY: 'Session'
# 09m 23s, expect passed
Single_Region_Fast:
Expand Down Expand Up @@ -190,7 +189,6 @@ jobs:
DisplayName: Single Region ReadMyWrites
OSVmImage: 'ubuntu-18.04'
ProfileFlag: '-Pe2e'
AdditionalArgs: '-DargLine="-Dcosmos.directModeProtocol=Https"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, currently on V3- we are not running e2e tests on Tcp mode, which is important as compared to running e2e tests on https mode.

DESIRED_CONSISTENCY: 'Strong'
# 08m 50s, expect passed
Strong_Https_Fast:
Expand Down