Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated the telemetry configuration item and remove the telemetry code usage. #22200

Merged

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Jun 10, 2021

Fixes #19719

Changelog:

  • Mark the telemetry configuration item of each module as deprecated.
  • Mark the module azure-spring-cloud-telemetry as deprecated, and remove the source code.
  • Remove telemetry code of spring cloud module.

Some more context here:

Azure Spring libraries used to collect telemetry data by sending them to a hosted telemetry track endpoint, but now with using track 2 Azure SDks, we could set some spring flags in the HTTP user-agent header. So now there's no need of such telemetry libraries except for libraries not developed by Azure SDK, such as the redis integration.

@saragluna saragluna self-assigned this Jun 11, 2021
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, do we delete the entry defined in the versioning client text file too?

@saragluna saragluna added this to the [2021] July milestone Jun 11, 2021
@saragluna
Copy link
Member

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna saragluna enabled auto-merge (squash) June 16, 2021 07:55
auto-merge was automatically disabled June 16, 2021 10:25

Head branch was pushed to by a user without write access

@saragluna
Copy link
Member

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] telemetry.instrumentationKey is not set in azure-spring-boot
2 participants