Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ContainerRegistryAudience in ACR #23434

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Add support for ContainerRegistryAudience in ACR #23434

merged 3 commits into from
Aug 11, 2021

Conversation

pallavit
Copy link
Contributor

@pallavit pallavit commented Aug 9, 2021

No description provided.

@pallavit pallavit marked this pull request as ready for review August 9, 2021 18:35
@pallavit pallavit self-assigned this Aug 9, 2021
alzimmermsft
alzimmermsft reviewed Aug 10, 2021
View reviewed changes
...try/src/main/java/com/azure/containers/containerregistry/ContainerRegistryClientBuilder.java Outdated Show resolved Hide resolved
...try/src/main/java/com/azure/containers/containerregistry/ContainerRegistryClientBuilder.java Outdated Show resolved Hide resolved
...containerregistry/implementation/authentication/ContainerRegistryRefreshTokenCredential.java Show resolved Hide resolved
...y/src/main/java/com/azure/containers/containerregistry/models/ContainerRegistryAudience.java Outdated Show resolved Hide resolved
...y/src/main/java/com/azure/containers/containerregistry/models/ContainerRegistryAudience.java Outdated Show resolved Hide resolved
...y/src/main/java/com/azure/containers/containerregistry/models/ContainerRegistryAudience.java Outdated Show resolved Hide resolved
...y/src/main/java/com/azure/containers/containerregistry/models/ContainerRegistryAudience.java Outdated Show resolved Hide resolved
...try/src/main/java/com/azure/containers/containerregistry/ContainerRegistryClientBuilder.java Show resolved Hide resolved
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@pallavit
Copy link
Contributor Author

Thank you for the review.

@pallavit pallavit merged commit 6c61e2b into Azure:main Aug 11, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Apr 13, 2023
@ramoka178 @markcowl
@stuti-1807 @giladsu @koyasu221b @mikekistler @minkefusiji @namanag16 @davidgamero @bfoley13 @msyyc @karishmadaga @vikotha @banggaurav
CodeGen from PR 23485 in Azure/azure-rest-api-specs
422a931 
Review request for Microsoft.ContainerInstance to add version stable/2023-05-01 (Azure#23485)

* Adds base for updating Microsoft.ContainerInstance from version preview/2022-10-01-preview to version 2023-05-01

* Updates readme

* Updates API version in new specs and examples

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23166)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23169)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23170)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23452)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* use old api versionf or operations

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23453)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* use old api versionf or operations

* revert Operations example api version

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23471)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* use old api versionf or operations

* revert Operations example api version

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23473)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* MGRP S360 Vuln (Azure#22832)

* Add blockchain to latest profile

* Add additional types

* Fix Swagger issues

* Solve validation

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* use old api versionf or operations

* Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)

* added example for the new field

* updated the double ref that was causing build failure

* Fixed PrometheusRuleGroups examples (Azure#23390)

* Fixed PrometheusRuleGroups examples

* One more fix

* Remvoe flattern (Azure#23460)

Co-authored-by: Will Huang <huangwill@microsoft.com>

* Mvad update (Azure#23434)

* Add default value 10 for topContributorCount

* Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings

* Update TypeSpec config

* Add back language emitter options

* Fix cspell and model validation errors

---------

Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* revert Operations example api version

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* use management.auzre.com endpoint

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23483)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* MGRP S360 Vuln (Azure#22832)

* Add blockchain to latest profile

* Add additional types

* Fix Swagger issues

* Solve validation

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* use old api versionf or operations

* Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)

* added example for the new field

* updated the double ref that was causing build failure

* Fixed PrometheusRuleGroups examples (Azure#23390)

* Fixed PrometheusRuleGroups examples

* One more fix

* Remvoe flattern (Azure#23460)

Co-authored-by: Will Huang <huangwill@microsoft.com>

* Mvad update (Azure#23434)

* Add default value 10 for topContributorCount

* Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings

* Update TypeSpec config

* Add back language emitter options

* Fix cspell and model validation errors

---------

Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* revert Operations example api version

* use management.auzre.com endpoint

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* fix package version in readme

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23484)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* MGRP S360 Vuln (Azure#22832)

* Add blockchain to latest profile

* Add additional types

* Fix Swagger issues

* Solve validation

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* use old api versionf or operations

* Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)

* added example for the new field

* updated the double ref that was causing build failure

* Fixed PrometheusRuleGroups examples (Azure#23390)

* Fixed PrometheusRuleGroups examples

* One more fix

* Remvoe flattern (Azure#23460)

Co-authored-by: Will Huang <huangwill@microsoft.com>

* Mvad update (Azure#23434)

* Add default value 10 for topContributorCount

* Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings

* Update TypeSpec config

* Add back language emitter options

* Fix cspell and model validation errors

---------

Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* revert Operations example api version

* add codeowners for Compute Instance swagger (Azure#23437)

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>

* [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (Azure#22828)

* Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview

* Updates readme

* Updates API version in new specs and examples

* start 10-11 preview

* add words

* fix readme version

* update swagger version

* add second putworkflow example

* fix generatepreviewartifactsresponse

* align generate preview artifacts example

* update param locations that got changed

* add x-ms-client-flatten for artifact properties

* Adding WorkflowRunStatus

* Fixing enum name

* add namespace to example

---------

Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>

* Update readme.python.md (Azure#23208)

* fixing async response type for machinelearningservices-2023-02-01-preview (Azure#23105)

* fixing regex pattern and async response type

* remove update to regex

* Fix lint error for Datadog RP (Azure#23477)

* Fix link error for Datadog RP

* Fix version

* merging billing fix to public repo (Azure#23424)

Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>

* use management.auzre.com endpoint

* fix package version in readme

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
Co-authored-by: Gaurav <bang.gourav@gmail.com>
Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>

* fix tag in readme

* update example with capabilities example

* fix typo

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
Co-authored-by: Gaurav <bang.gourav@gmail.com>
Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

Assignees

@pallavit pallavit

Labels
Container Registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pallavit @alzimmermsft