drop rxjava and completableFuture api #24326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiliuTo
added
Client
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yiliuTo
requested review from
backwind1233,
chenrujun,
michaelqi793,
moarychan,
saragluna,
stliu,
zhichengliu12581 and
ZhuXiaoBing-cn
as code owners
saragluna
requested changes
Sep 26, 2021
| @@ -60,13 +60,17 @@ protected void internalSubscribe(String name, Consumer<Message<?>> consumer, Cla | |||
| this.checkpointConfig, payloadType, consumer, this.messageConverter) { | |||
|
|
|||
| @Override | |||
| protected String buildCheckpointFailMessage(Message<?> message) { | |||
| return String.format(MSG_FAIL_CHECKPOINT, message, name); | |||
| protected void buildCheckpointFailMessage(Message<?> message, Throwable t) { | |||
There was a problem hiding this comment.
If this method is used to log information, should we change the method names accordingly?
| } | ||
|
|
||
| @Override | ||
| protected String buildCheckpointSuccessMessage(Message<?> message) { | ||
| return String.format(MSG_SUCCESS_CHECKPOINT, message, name, getCheckpointConfig().getCheckpointMode()); | ||
| protected void buildCheckpointSuccessMessage(Message<?> message) { |
| @@ -98,14 +98,18 @@ protected void internalSubscribe(String name, | |||
| final DefaultServiceBusMessageProcessor messageProcessor = new DefaultServiceBusMessageProcessor( | |||
| this.checkpointConfig, payloadType, consumer, this.messageConverter) { | |||
| @Override | |||
| protected String buildCheckpointFailMessage(Message<?> message) { | |||
| return String.format(MSG_FAIL_CHECKPOINT, consumer, name, message); | |||
| protected void buildCheckpointFailMessage(Message<?> message, Throwable t) { | |||
| protected String buildCheckpointSuccessMessage(Message<?> message) { | ||
| return String.format(MSG_SUCCESS_CHECKPOINT, consumer, name, message, | ||
| getCheckpointConfig().getCheckpointMode()); | ||
| protected void buildCheckpointSuccessMessage(Message<?> message) { |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saragluna
requested changes
Sep 27, 2021
| @@ -1,7 +1,7 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Licensed under the MIT License. | |||
|
|
|||
| package com.azure.spring.servicebus.core; | |||
| package com.azure.spring.servicebus.resourcemanager; | |||
There was a problem hiding this comment.
How about we name this package as xxx.provisioning, Just like org.springframework.cloud.stream.provisioning.ProvisioningProvider?
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stliu
approved these changes
Sep 27, 2021
4 tasks
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Jun 7, 2023
[TypeSpec] Upgrade to 0.45.0 (Azure#24326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to drop rxjava and CompletableFuture support in spring cloud for azure messaging modules.