mgmt, sample for mock sdk #24849
Merged
mgmt, sample for mock sdk #24849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
added
Mgmt
weidongxu-microsoft
requested review from
ArthurMa1978,
haolingdong-msft and
XiaofeiCao
as code owners
|
README will be updated later. I first need to put the files into repo so the README can refer to them without CI report url-not-found error. |
|
/azp run java - resourcemanager - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -0,0 +1 @@ | |||
| mock-maker-inline | |||
There was a problem hiding this comment.
why is this file under test/resources folder rather than sample/resources folder?
There was a problem hiding this comment.
this is for enabling feature on mockito to enable mocking of final class.
see https://github.com/Azure/azure-sdk-for-java/wiki/Unit-Testing#mocking-final-classes and its reference to mockito.
haolingdong-msft
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most desirable approach for mocking Fluent API would be the “Mockito.RETURNS_DEEP_STUBS” provided by Mockito.
However some of the interfaces involved in our API uses generic, and due to type erasure Mockito will not able to handle them. Hence we still need to use the full declaration on every step of the Fluent API.