mgmt, support HttpPipelinePosition in pipeline creation #25189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaofeiCao
requested review from
ArthurMa1978,
haolingdong-msft and
weidongxu-microsoft
as code owners
| import com.azure.core.http.policy.RequestIdPolicy; | ||
| import com.azure.core.http.policy.RetryPolicy; | ||
| import com.azure.core.http.HttpPipelinePosition; | ||
| import com.azure.core.http.policy.*; |
There was a problem hiding this comment.
configure your IDE to avoid *
| @@ -69,15 +63,28 @@ public static HttpPipeline buildHttpPipeline( | |||
| policies.add(new AddHeadersFromContextPolicy()); | |||
| policies.add(new RequestIdPolicy()); | |||
| policies.add(new ReturnRequestIdHeaderPolicy(ReturnRequestIdHeaderPolicy.Option.COPY_CLIENT_REQUEST_ID)); | |||
| if(additionalPolicies != null && !additionalPolicies.isEmpty()){ | |||
There was a problem hiding this comment.
you probably going to fail style check.
There was a problem hiding this comment.
easier to use CoreUtils.isNullOrEmpty()
| @@ -0,0 +1,177 @@ | |||
| package com.azure.resourcemanager.resources; | |||
|
You may want to check with Haoling about coding styles. see https://github.com/Azure/azure-sdk-for-java/wiki/Building for local build. (Java other than 11 or 17 might have problem on javadoc build). |
| @@ -69,15 +63,28 @@ public static HttpPipeline buildHttpPipeline( | |||
| policies.add(new AddHeadersFromContextPolicy()); | |||
| policies.add(new RequestIdPolicy()); | |||
| policies.add(new ReturnRequestIdHeaderPolicy(ReturnRequestIdHeaderPolicy.Option.COPY_CLIENT_REQUEST_ID)); | |||
| if(additionalPolicies != null && !additionalPolicies.isEmpty()){ | |||
There was a problem hiding this comment.
easier to use CoreUtils.isNullOrEmpty()
| */ | ||
| public class HttpPipelineProviderTest { | ||
|
|
||
| static class MockTokenCredential implements TokenCredential { |
There was a problem hiding this comment.
tests is nice!
you can use mockito e.g. #24849
2. mockito use in unit test
weidongxu-microsoft
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #25060