Add Context to RequestOptions #25134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
alzimmermsft
requested review from
anuchandy,
JonathanGiles,
lmolkova,
mssfang,
pallavit,
srnagar and
vcolin7
as code owners
|
API changes have been detected in API changes + public RequestOptions setContext(Context context) |
sdk/core/azure-core/src/main/java/com/azure/core/http/rest/RestProxy.java
Outdated
Show resolved
Hide resolved
joshfree
approved these changes
Nov 2, 2021
sdk/core/azure-core/src/main/java/com/azure/core/http/rest/RestProxy.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/http/rest/RestProxy.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/Context.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/Context.java
Outdated
Show resolved
Hide resolved
| RequestOptions options = methodParser.setRequestOptions(args); | ||
| if (options != null) { | ||
| Context optionsContext = options.getContext(); | ||
| if (optionsContext != null && optionsContext != Context.NONE) { |
There was a problem hiding this comment.
should we add a perf test for this?
/cc @g2vinay
|
/check-enforcer override |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Aug 25, 2023
[Fleet] API 2023-06-15-preview (Azure#25027) * Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview * Updates readme * Updates API version in new specs and examples * [Fleet][Dev] API 0615 changes (Azure#25020) * Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview * Updates readme * Updates API version in new specs and examples * sync with ADO repo * exclude unneeded file changes * revert tsp config * revert helpers.tsp * remove package files * remove package files * add known word containerd * format * remove .npmrc * revert custom word * revert package-lock.json * re-generate json * add example * add example * fix read-only fields * fix read-only fields * re-generate json with latest compiler * add custom word back * re-generate json * restore config * add examples * add examples * add examples * add examples * add examples * add examples * prettier * fix examples * git ignore * review commoents * fix examples * make node image selection optional * fix warnings * fix warnings * fix warnings * fix docs * revert package changes * compile * fix tspconfig (Azure#25031) * [Fleet][readmes] Dev aks fleet 2023 06 15 preview readmes (Azure#25033) * update readmes * fix readme mistake * fix operationid warnings (Azure#25109) * tsp format (Azure#25111) * Fix aks fleet 2023 06 15 preview patchasync from 0615 (Azure#25131) * do the breaking change only from 0615 * fix patch * compile to get examples * remove sample * fix member upate operation (Azure#25134) * revert extension removal (Azure#25189) * generate with type spec v0.47.0 (Azure#25484) --------- Co-authored-by: Stéphane Erbrech <stephane.erbrech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ContexttoRequestOptions. HavingContextonRequestOptionsallows for a simplification of LLC APIs.RequestOptionsshould only be used in LLC APIs, so this won't affect current SDKs.