mgmt, compute support withplan for VMSS #25323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haolingdong-msft
requested review from
ArthurMa1978,
weidongxu-microsoft and
XiaofeiCao
as code owners
weidongxu-microsoft
approved these changes
Nov 11, 2021
Comment on lines
130
to
131
| .withUnmanagedDisks() | ||
| .withNewStorageAccount(generateRandomResourceName("stg", 15)) |
There was a problem hiding this comment.
Avoid using unmanaged disk.
| .withRegion(region) | ||
| .withExistingResourceGroup(resourceGroup) | ||
| .withSku(VirtualMachineScaleSetSkuTypes.STANDARD_A0) | ||
| .withExistingPrimaryNetworkSubnet(network, "subnet1") |
There was a problem hiding this comment.
Usually it is easier to call withNewNetwork?
There was a problem hiding this comment.
I refer to other tests to add the network configuration part, will try withNewNetWork(). Thanks
| @@ -382,6 +382,11 @@ RunCommandResult runShellScriptInVMInstance( | |||
| */ | |||
| AdditionalCapabilities additionalCapabilities(); | |||
|
|
|||
| /** | |||
| * @return the plan value | |||
There was a problem hiding this comment.
Do we have a better javadoc? the plan value is just useless as the method is already called plan()...
| @@ -127,7 +127,7 @@ public void canCreateVMSSWithPlan() { | |||
| .withSpecificLinuxImageVersion(imageReference) | |||
| .withRootUsername(uname) | |||
| .withSsh(sshPublicKey()) | |||
| .withUnmanagedDisks() | |||
| .withNewDataDisk(1) | |||
| .withNewStorageAccount(generateRandomResourceName("stg", 15)) | |||
There was a problem hiding this comment.
I don't think you need the storage account?
XiaofeiCao
pushed a commit
to XiaofeiCao/azure-sdk-for-java
that referenced
this pull request
Nov 18, 2021
* Code change to support withplan for compute virtual machine scale set * Add test to create VMSS with plan * Add session records * Update CHANGELOG * Update test to use withNewDataDisk() instead of withUnmanagedDisks() * Remove withNewStorageAccount() in test * update javadoc * Update session-records due to network upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add feature, issue link: #24301
Code Change
VirtualMachineScaleSetandVirtualMachineScaleSetImplto add withPlan() interface and plan() getterIf an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines