Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, compute support withplan for VMSS #25323

Merged
merged 9 commits into from
Nov 15, 2021
Merged

mgmt, compute support withplan for VMSS #25323

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b3cee5
Code change to support withplan for compute virtual machine scale set
haolingdong-msft Nov 11, 2021
07c7d58
Add test to create VMSS with plan
haolingdong-msft Nov 11, 2021
e493233
Add session records
haolingdong-msft Nov 11, 2021
78399ac
Update CHANGELOG
haolingdong-msft Nov 11, 2021
12d7992
Update test to use withNewDataDisk() instead of withUnmanagedDisks()
haolingdong-msft Nov 11, 2021
77f382e
Remove withNewStorageAccount() in test
haolingdong-msft Nov 11, 2021
7837250
update javadoc
haolingdong-msft Nov 11, 2021
aee45fb
Merge remote-tracking branch 'remote/main' into compute-withplan
haolingdong-msft Nov 15, 2021
6877ead
Update session-records due to network upgrade
haolingdong-msft Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rc/test/java/com/azure/resourcemanager/compute/VirtualMachineScaleSetOperationsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public void canCreateVMSSWithPlan() {
.withSpecificLinuxImageVersion(imageReference)
.withRootUsername(uname)
.withSsh(sshPublicKey())
.withUnmanagedDisks()
.withNewDataDisk(1)
.withNewStorageAccount(generateRandomResourceName("stg", 15))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the storage account?

.withPlan(plan)
.create();
Expand Down
Loading