-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Java 17 as the LTS Version #27938
Use Java 17 as the LTS Version #27938
Conversation
/azp run java - keyvault - data |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run java - keyvault - data |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - keyvault - data |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - keyvault - data |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - keyvault - data |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - identity |
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
@@ -8,7 +8,7 @@ | |||
"windows-2019": { "OSVmImage": "MMS2019", "Pool": "azsdk-pool-mms-win-2019-general" }, | |||
"macOS-10.15": { "OSVmImage": "macOS-10.15", "Pool": "Azure Pipelines" } | |||
}, | |||
"JavaTestVersion": [ "1.8", "1.11" ], | |||
"JavaTestVersion": [ "1.8", "1.17" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep one job with 11 or 9 (as long as core compiles partially with 9).
...onfig/src/main/java/com/azure/spring/cloud/config/AppConfigurationPropertySourceLocator.java
Show resolved
Hide resolved
...onfig/src/main/java/com/azure/spring/cloud/config/AppConfigurationPropertySourceLocator.java
Show resolved
Hide resolved
...n/java/com/microsoft/azure/spring/cloud/config/web/AppConfigurationWebAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...n/java/com/microsoft/azure/spring/cloud/config/web/AppConfigurationWebAutoConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these changes are incorrect for the Spring App Config library. And will need to deal with the latest version in review. #28701
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
/azp run java - spring - tests |
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/check-enforcer override |
Live tests have been validated that their completion matches most recent runs without Java 17 in CI |
Description
This PR updates the pipelines to use Java 17 instead of Java 11 as the LTS build version. There is a new parameter in ci.yml named
JavaBuildVersion
to allow libraries to continue using Java 11 as the LTS version while incompatibilities with Java 17 are resolved (such as using JDK internals that are no longer accessible through reflection or dependencies that don't support Java 17 such as PowerMock).Most files changed in this PR are updates to Javadocs.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines