Sync-Stack: Tables #33143

jairmyree · 2023-01-23T17:50:14Z

Introducing a fully synchronous implementation of the Tables synchronous clients, replacing the sync-over-asynchronous implementation.

Includes test improvements and updated code generation to fix failing live tests for both synchronous and asynchronous clients.

� Conflicts: � sdk/search/azure-search-documents/CHANGELOG.md

… non-main patch release for Search

…to jairmyree/tables-sync-stack

azure-sdk · 2023-01-23T18:17:35Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-data-tables

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableAsyncClient.java

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClientBuilder.java

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableServiceClient.java

...bles/azure-data-tables/src/main/java/com/azure/data/tables/models/TableSignedIdentifier.java

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java

- Added Synchronous Rest Proxy Context - Added Trailing Context Checkstyle adjustments

vcolin7 · 2023-01-26T03:59:45Z

If I'm not mistaken, we also added a way of creating an asserting client for both our sync and async tests like in this commit. @g2vinay what's the reason for this? Is it required by all libraries that now support the new sync stack?

@vcolin7 Yes, it is required for all libs moving to sync stack integration. The asserting clients help ensure that the call stack for sync and async APIs is completely synchronous or asynchronous in nature respectively.

You'll need to add this to the PR as well then @jairmyree.

g2vinay · 2023-01-30T17:19:31Z

Adding Asserting Client to Sync and Async Tables client setup.
Run Performance tests both sync and async for this PR against last stable release version.

sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTestBase.java

...tables/azure-data-tables/src/test/java/com/azure/data/tables/TableServiceClientTestBase.java

vcolin7

I have yet to review the batch operations code, but added comments for everything else :)

...ables/azure-data-tables/src/test/java/com/azure/data/tables/TableServiceAsyncClientTest.java

sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableServiceClientTest.java

sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java

sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableAsyncClientTest.java

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableServiceClientBuilder.java

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableServiceClient.java

vcolin7 · 2023-02-11T00:38:48Z

I reviewed the sync submitTransactionWithResponse() code and the logic looks good to me :)

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java

samvaity

Sync stack changes lgtm!
Left some comments for code refactoring. (can be addressed in a separate PR).
Make sure to run Live tests before merging the PR.

samvaity · 2023-02-24T19:32:36Z

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java

+        AzureNamedKeyCredential azureNamedKeyCredential = TableSasUtils.extractNamedKeyCredential(getHttpPipeline());
+
+        if (azureNamedKeyCredential == null) {
+            throw logger.logExceptionAsError(new IllegalStateException("Cannot generate a SAS token with a client that"


Consider putting these strings into util.Constants so they can be shared with asyn client.

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java

jairmyree · 2023-02-24T20:01:24Z

/azp run java - tables - tests

azure-pipelines · 2023-02-24T20:01:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jairmyree · 2023-02-24T21:55:50Z

/azp run java - tables - tests

azure-pipelines · 2023-02-24T21:56:05Z

Azure Pipelines successfully started running 1 pipeline(s).

vcolin7

LGTM!

jairmyree and others added 8 commits November 10, 2022 15:42

Prepare November 2022 Beta Release for Search

05e268c

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java

294121f

� Conflicts: � sdk/search/azure-search-documents/CHANGELOG.md

Cherry-Pick updates to Changelog and version_client.txt from November…

8714080

… non-main patch release for Search

Autorest regeneration with Sync Stack

548aa95

Stashing my sync stack work

e625125

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

b873e7e

…to jairmyree/tables-sync-stack

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

d01ded6

…to jairmyree/tables-sync-stack

Synchronous implementation of our Clients

65b2998

jairmyree requested review from vcolin7 and conniey as code owners January 23, 2023 17:50

jairmyree requested review from g2vinay, samvaity and alzimmermsft January 23, 2023 17:50

Update to CHANGELOG.md

8ad09df

jairmyree changed the title ~~Jairmyree/tables sync stack~~ Sync-Stack: Tables Jan 23, 2023

Fix PR build issues

6b1ebf9

samvaity assigned jairmyree Jan 23, 2023

Fix PR build issues

373ed43

samvaity reviewed Jan 23, 2023

View reviewed changes

Removed TODOs left behind.

ed29956

samvaity reviewed Jan 23, 2023

View reviewed changes

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java Outdated Show resolved Hide resolved

jairmyree added 7 commits January 23, 2023 10:54

Adjusting whitespaces

bb77546

Removing unnecessary annotation

d87f51d

Adjustments to how context information:

3638028

- Added Synchronous Rest Proxy Context - Added Trailing Context Checkstyle adjustments

Removed unused import

eab0151

Fixed issues identified by Spotbugs

f324cb6

Bug fixes

582a70e

Checkstyle fixes

6229ca1

Added Asserting Clients

0648b01

samvaity mentioned this pull request Jan 31, 2023

Regenerate SDKs to Use Sync Stack #30634

Closed

g2vinay reviewed Jan 31, 2023

View reviewed changes

sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTestBase.java Outdated Show resolved Hide resolved

g2vinay reviewed Jan 31, 2023

View reviewed changes

...tables/azure-data-tables/src/test/java/com/azure/data/tables/TableServiceClientTestBase.java Outdated Show resolved Hide resolved

Add asserting client to clients used for playback

13c067e

vcolin7 reviewed Feb 8, 2023

View reviewed changes

g2vinay reviewed Feb 10, 2023

View reviewed changes

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableServiceClient.java Outdated Show resolved Hide resolved

Replaced method threads with a static Thread Pool

f92f51e

g2vinay reviewed Feb 16, 2023

View reviewed changes

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java Outdated Show resolved Hide resolved

jairmyree added 4 commits February 21, 2023 14:09

Tables Refactoring

988b026

Updating to only use threadpool for timeout cases.

8d77fc5

Additional refactoring

b88706a

Removed unused imports

95e7fbb

jairmyree requested review from g2vinay, vcolin7 and samvaity February 24, 2023 17:49

Fixed Checkstyle Issues

93320f8

samvaity approved these changes Feb 24, 2023

View reviewed changes

jairmyree mentioned this pull request Feb 24, 2023

Tables | Refactoring Opportunitites #33736

Closed

Bug fix for failing Cosmos test

3e72216

vcolin7 approved these changes Feb 27, 2023

View reviewed changes

jairmyree merged commit 8130060 into main Mar 3, 2023

jairmyree deleted the jairmyree/tables-sync-stack branch March 3, 2023 18:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync-Stack: Tables #33143

Sync-Stack: Tables #33143

jairmyree commented Jan 23, 2023

azure-sdk commented Jan 23, 2023

vcolin7 commented Jan 26, 2023 •

edited

Loading

g2vinay commented Jan 30, 2023

vcolin7 left a comment

vcolin7 commented Feb 11, 2023

samvaity left a comment •

edited

Loading

samvaity Feb 24, 2023

jairmyree commented Feb 24, 2023

azure-pipelines bot commented Feb 24, 2023

jairmyree commented Feb 24, 2023

azure-pipelines bot commented Feb 24, 2023

vcolin7 left a comment

Sync-Stack: Tables #33143

Sync-Stack: Tables #33143

Conversation

jairmyree commented Jan 23, 2023

azure-sdk commented Jan 23, 2023

vcolin7 commented Jan 26, 2023 • edited Loading

g2vinay commented Jan 30, 2023

vcolin7 left a comment

Choose a reason for hiding this comment

vcolin7 commented Feb 11, 2023

samvaity left a comment • edited Loading

Choose a reason for hiding this comment

samvaity Feb 24, 2023

Choose a reason for hiding this comment

jairmyree commented Feb 24, 2023

azure-pipelines bot commented Feb 24, 2023

jairmyree commented Feb 24, 2023

azure-pipelines bot commented Feb 24, 2023

vcolin7 left a comment

Choose a reason for hiding this comment

vcolin7 commented Jan 26, 2023 •

edited

Loading

samvaity left a comment •

edited

Loading