Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync-Stack: Tables #33143

Merged
merged 28 commits into from
Mar 3, 2023
Merged

Sync-Stack: Tables #33143

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
05e268c
Prepare November 2022 Beta Release for Search
jairmyree Nov 10, 2022
294121f
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java
jairmyree Nov 28, 2022
8714080
Cherry-Pick updates to Changelog and version_client.txt from November…
azure-sdk Nov 11, 2022
548aa95
Autorest regeneration with Sync Stack
jairmyree Nov 29, 2022
e625125
Stashing my sync stack work
jairmyree Jan 3, 2023
b873e7e
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…
jairmyree Jan 17, 2023
d01ded6
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…
jairmyree Jan 18, 2023
65b2998
Synchronous implementation of our Clients
jairmyree Jan 23, 2023
8ad09df
Update to CHANGELOG.md
jairmyree Jan 23, 2023
6b1ebf9
Fix PR build issues
jairmyree Jan 23, 2023
373ed43
Fix PR build issues
jairmyree Jan 23, 2023
ed29956
Removed TODOs left behind.
jairmyree Jan 23, 2023
bb77546
Adjusting whitespaces
jairmyree Jan 23, 2023
d87f51d
Removing unnecessary annotation
jairmyree Jan 23, 2023
3638028
Adjustments to how context information:
jairmyree Jan 24, 2023
eab0151
Removed unused import
jairmyree Jan 24, 2023
f324cb6
Fixed issues identified by Spotbugs
jairmyree Jan 24, 2023
582a70e
Bug fixes
jairmyree Jan 24, 2023
6229ca1
Checkstyle fixes
jairmyree Jan 24, 2023
0648b01
Added Asserting Clients
jairmyree Jan 30, 2023
13c067e
Add asserting client to clients used for playback
jairmyree Feb 1, 2023
f92f51e
Replaced method threads with a static Thread Pool
jairmyree Feb 14, 2023
988b026
Tables Refactoring
jairmyree Feb 21, 2023
8d77fc5
Updating to only use threadpool for timeout cases.
jairmyree Feb 23, 2023
b88706a
Additional refactoring
jairmyree Feb 23, 2023
95e7fbb
Removed unused imports
jairmyree Feb 24, 2023
93320f8
Fixed Checkstyle Issues
jairmyree Feb 24, 2023
3e72216
Bug fix for failing Cosmos test
jairmyree Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/tables/azure-data-tables/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Bugs Fixed

### Other Changes
- Removed Reactor from synchronous clients

## 12.3.7 (2023-01-11)

Expand Down
21 changes: 11 additions & 10 deletions sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableAsyncClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ public String generateSas(TableSasSignatureValues tableSasSignatureValues) {
return new TableSasGenerator(tableSasSignatureValues, getTableName(), azureNamedKeyCredential).getSas();
}


/**
* Creates the table within the Tables service.
*
Expand Down Expand Up @@ -287,7 +288,7 @@ public Mono<Response<TableItem>> createTableWithResponse() {
}

Mono<Response<TableItem>> createTableWithResponse(Context context) {
context = context == null ? Context.NONE : context;
context = TableUtils.setContext(context);
final TableProperties properties = new TableProperties().setTableName(tableName);

try {
Expand Down Expand Up @@ -349,7 +350,7 @@ public Mono<Response<Void>> deleteTableWithResponse() {
}

Mono<Response<Void>> deleteTableWithResponse(Context context) {
context = context == null ? Context.NONE : context;
context = TableUtils.setContext(context);

try {
return tablesImplementation.getTables().deleteWithResponseAsync(tableName, null, context)
Expand Down Expand Up @@ -432,7 +433,7 @@ public Mono<Response<Void>> createEntityWithResponse(TableEntity entity) {
}

Mono<Response<Void>> createEntityWithResponse(TableEntity entity, Context context) {
context = context == null ? Context.NONE : context;
context = TableUtils.setContext(context);

if (entity == null) {
return monoError(logger, new IllegalArgumentException("'entity' cannot be null."));
Expand Down Expand Up @@ -532,7 +533,7 @@ public Mono<Response<Void>> upsertEntityWithResponse(TableEntity entity, TableEn

Mono<Response<Void>> upsertEntityWithResponse(TableEntity entity, TableEntityUpdateMode updateMode,
Context context) {
context = context == null ? Context.NONE : context;
context = TableUtils.setContext(context);

if (entity == null) {
return monoError(logger, new IllegalArgumentException("'entity' cannot be null."));
Expand Down Expand Up @@ -699,7 +700,7 @@ public Mono<Response<Void>> updateEntityWithResponse(TableEntity entity, TableEn

Mono<Response<Void>> updateEntityWithResponse(TableEntity entity, TableEntityUpdateMode updateMode,
boolean ifUnchanged, Context context) {
context = context == null ? Context.NONE : context;
context = TableUtils.setContext(context);

if (entity == null) {
return monoError(logger, new IllegalArgumentException("'entity' cannot be null."));
Expand Down Expand Up @@ -839,7 +840,7 @@ public Mono<Response<Void>> deleteEntityWithResponse(TableEntity entity, boolean

Mono<Response<Void>> deleteEntityWithResponse(String partitionKey, String rowKey, String eTag, boolean ifUnchanged,
Context context) {
context = context == null ? Context.NONE : context;
context = TableUtils.setContext(context);
eTag = ifUnchanged ? eTag : "*";

if (isNullOrEmpty(partitionKey) || isNullOrEmpty(rowKey)) {
Expand Down Expand Up @@ -967,7 +968,7 @@ private <T extends TableEntity> Mono<PagedResponse<T>> listEntitiesNextPage(Stri
private <T extends TableEntity> Mono<PagedResponse<T>> listEntities(String nextPartitionKey, String nextRowKey,
Context context, ListEntitiesOptions options,
Class<T> resultType) {
context = context == null ? Context.NONE : context;
context = TableUtils.setContext(context);
String select = null;

if (options.getSelect() != null) {
Expand Down Expand Up @@ -1248,7 +1249,7 @@ public Mono<Response<TableAccessPolicies>> getAccessPoliciesWithResponse() {
}

Mono<Response<TableAccessPolicies>> getAccessPoliciesWithResponse(Context context) {
context = context == null ? Context.NONE : context;
context = TableUtils.setContext(context);

try {
return tablesImplementation.getTables()
Expand Down Expand Up @@ -1368,7 +1369,7 @@ public Mono<Response<Void>> setAccessPoliciesWithResponse(List<TableSignedIdenti

Mono<Response<Void>> setAccessPoliciesWithResponse(List<TableSignedIdentifier> tableSignedIdentifiers,
Context context) {
context = context == null ? Context.NONE : context;
context = TableUtils.setContext(context);
List<SignedIdentifier> signedIdentifiers = null;

/*
Expand Down Expand Up @@ -1617,7 +1618,7 @@ public Mono<Response<TableTransactionResult>> submitTransactionWithResponse(List
}

Mono<Response<TableTransactionResult>> submitTransactionWithResponse(List<TableTransactionAction> transactionActions, Context context) {
Context finalContext = context == null ? Context.NONE : context;
Context finalContext = TableUtils.setContext(context);

if (transactionActions.isEmpty()) {
return monoError(logger,
Expand Down
Loading