-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cosmos] Computed properties support #35046
Conversation
…to users/balalakshmin/computedprops
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/ContainerPropertiesTest.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/ContainerPropertiesTest.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ComputedProperty.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosContainerProperties.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ComputedProperty.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ComputedProperty.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosContainerProperties.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly blocking in the probably incomplete JsonSerializable implementation.
…/Azure/azure-sdk-for-java into users/balalakshmin/computedprops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now...
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/ContainerPropertiesTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @balalakshmin, they look great.
One new process that we are starting now is to make sure that every feature PR also adds samples / documentation about the feature.
For this one, I think we should add the code snippet about this feature, in the samples folder, and then reference those code snippets in the java docs on these APIs.
You can see the example of throughput control / change feed processor, also this sample PR will show you how / where to add the code snippets - #35300
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ComputedProperty.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
…to users/balalakshmin/computedprops
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @balalakshmin !
@@ -0,0 +1,79 @@ | |||
package com.azure.cosmos; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new file license header. Can be added later on after CI finishes.
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Adding computed properties support in
CosmosContainerProperties
.Corresponding .Net PR
Usage
All SDK Contribution checklist:
Testing Guidelines