Improve api docs cosmos db #35300
Merged
Improve api docs cosmos db #35300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangerinous
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
|
API change check API changes are not detected in this pull request. |
kushagraThapar
approved these changes
Jun 5, 2023
| @@ -0,0 +1,152 @@ | |||
| package com.azure.cosmos; | |||
There was a problem hiding this comment.
missing new file license header
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| public class ContainerAsyncCodeSnippets { |
There was a problem hiding this comment.
Suggested change
| public class ContainerAsyncCodeSnippets { | |
| public class AsyncContainerCodeSnippets { |
There was a problem hiding this comment.
Thanks for your feedback. I have renamed this class.
| private final String serviceEndpoint = "<service-endpoint>"; | ||
| private final String key = "<key>"; | ||
| private final DirectConnectionConfig directConnectionConfig = new DirectConnectionConfig(); | ||
| private final GatewayConnectionConfig gatewayConnectionConfig = new GatewayConnectionConfig(); |
There was a problem hiding this comment.
looks like these connection configs are not used.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds additional information to the java docs according to the issue
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines