[KeyVault] - Address a few items for keys and admin and bump service …

…version (#13759)

## What

- Move `curve` from `createECKeyOptions` to `createKeyOptions`
- Add sample clatifying when `CertificatePolicy.contentType` is required
- Bump the API version to 7.2 (and update recordings)

## Why

- `createKeyOptions` is the catch-all and should accept parameters for all possible key creations (fixes #11263)
- It's not entirely clear when contentType is required. Following dotnet's example here (fixes #12309)
- 7.2 is already supported, and we will not GA with 7.2-preview (fixes #13594)

sdk/keyvault/keyvault-admin/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## 4.0.0-beta.3 (Unreleased)
 
+- Updated the Latest service version to 7.2.
+
 ## 4.0.0-beta.2 (2021-02-09)
 
 - [Breaking] Removed `dist-browser` from the published package. To bundle the Azure SDK libraries for the browsers, please read our bundling guide: [link](https://github.com/Azure/azure-sdk-for-js/blob/master/documentation/Bundling.md).

sdk/keyvault/keyvault-admin/review/keyvault-admin.api.md

@@ -148,7 +148,7 @@ export interface KeyVaultRoleDefinition {
 export type KeyVaultRoleScope = "/" | "/keys" | string;
 
 // @public
-export const LATEST_API_VERSION = "7.2-preview";
+export const LATEST_API_VERSION = "7.2";
 
 // @public
 export interface ListRoleAssignmentsOptions extends coreHttp.OperationOptions {
@@ -186,7 +186,7 @@ export interface SelectiveRestoreOperationState extends KeyVaultAdminPollOperati
 }
 
 // @public
-export type SUPPORTED_API_VERSIONS = "7.2-preview";
+export type SUPPORTED_API_VERSIONS = "7.2";
 
 // @public
 export interface UpsertRoleDefinitionOptions extends coreHttp.OperationOptions {

sdk/keyvault/keyvault-admin/src/constants.ts

@@ -9,9 +9,9 @@ export const SDK_VERSION: string = "4.0.0-beta.3";
 /**
  * The latest supported Key Vault service API version.
  */
-export const LATEST_API_VERSION = "7.2-preview";
+export const LATEST_API_VERSION = "7.2";
 
 /**
  * Supported API versions
  */
-export type SUPPORTED_API_VERSIONS = "7.2-preview";
+export type SUPPORTED_API_VERSIONS = "7.2";

sdk/keyvault/keyvault-admin/src/generated/keyVaultClientContext.ts

@@ -37,6 +37,6 @@ export class KeyVaultClientContext extends coreHttp.ServiceClient {
     this.baseUri = options.endpoint || "{vaultBaseUrl}";
 
     // Assigning values to Constant parameters
-    this.apiVersion = options.apiVersion || "7.2-preview";
+    this.apiVersion = options.apiVersion || "7.2";
   }
 }

sdk/keyvault/keyvault-admin/src/generated/models/parameters.ts

@@ -69,7 +69,7 @@ export const roleDefinitionName: OperationURLParameter = {
 export const apiVersion: OperationQueryParameter = {
   parameterPath: "apiVersion",
   mapper: {
-    defaultValue: "7.2-preview",
+    defaultValue: "7.2",
     isConstant: true,
     serializedName: "api-version",
     type: {

sdk/keyvault/keyvault-admin/test/internal/serviceVersionParameter.spec.ts

@@ -11,7 +11,7 @@ import { env } from "@azure/test-utils-recorder";
 import { URL } from "url";
 
 // Adding this to the source would change the public API.
-type ApIVersions = "7.2-preview";
+type ApIVersions = "7.2";
 
 describe("The keyvault-admin clients should set the serviceVersion", () => {
   function makeHTTPMock(path: string, status = 200): HttpClient {
@@ -68,7 +68,7 @@ describe("The keyvault-admin clients should set the serviceVersion", () => {
     });
 
     it("it should allow us to specify an API version from a specific set of versions", async function() {
-      const serviceVersion = "7.2-preview";
+      const serviceVersion = "7.2";
       const client = new KeyVaultAccessControlClient(env.KEYVAULT_URI, credential, {
         serviceVersion: serviceVersion as ApIVersions,
         httpClient: mockHttpClient
@@ -101,7 +101,7 @@ describe("The keyvault-admin clients should set the serviceVersion", () => {
     });
 
     it("it should allow us to specify an API version from a specific set of versions", async function() {
-      const serviceVersion = "7.2-preview";
+      const serviceVersion = "7.2";
       const client = new KeyVaultBackupClient(env.KEYVAULT_URI, credential, {
         serviceVersion: serviceVersion as ApIVersions,
         httpClient: mockHttpClient

sdk/keyvault/keyvault-certificates/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## 4.2.0-beta.3 (Unreleased)
 
+- Updated the Latest service version to 7.2.
+- Added a sample demonstrating how to import PFX / PEM certificates.
+
 ## 4.2.0-beta.2 (2021-02-09)
 
 - [Breaking] Removed `dist-browser` from the published package. To bundle the Azure SDK libraries for the browsers, please read our bundling guide: [link](https://github.com/Azure/azure-sdk-for-js/blob/master/documentation/Bundling.md).