Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault Keys] createKey should accept "curve". #11263

Closed
sadasant opened this issue Sep 15, 2020 · 0 comments · Fixed by #13759
Closed

[Key Vault Keys] createKey should accept "curve". #11263

sadasant opened this issue Sep 15, 2020 · 0 comments · Fixed by #13759
Assignees
@sadasant @maorleger
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] March

Comments

@sadasant
Copy link
Contributor

The current createKey method should accept "curve" as an optional property. createKey is the catch-all method for all of the possible key creations, this includes the "curve" property.

I found this was missing through this PR: #11245 (comment)
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Sep 15, 2020
@sadasant sadasant self-assigned this Sep 15, 2020
@sadasant sadasant mentioned this issue Sep 15, 2020
Closed
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Sep 15, 2020
This was referenced Sep 16, 2020
Closed
Closed
@sadasant sadasant modified the milestones: Backlog, [2021] March Jan 25, 2021
@maorleger maorleger mentioned this issue Feb 11, 2021
Merged
2 tasks
maorleger added a commit that referenced this issue Feb 16, 2021
@maorleger
[KeyVault] - Address a few items for keys and admin and bump service …
35fb851 
…version (#13759)

## What

- Move `curve` from `createECKeyOptions` to `createKeyOptions`
- Add sample clatifying when `CertificatePolicy.contentType` is required
- Bump the API version to 7.2 (and update recordings)

## Why

- `createKeyOptions` is the catch-all and should accept parameters for all possible key creations (fixes #11263)
- It's not entirely clear when contentType is required. Following dotnet's example here (fixes #12309)
- 7.2 is already supported, and we will not GA with 7.2-preview (fixes #13594)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] March
3 participants
@sadasant @maorleger @ramya-rao-a