Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyvault] Regenerate swagger using Autorest Typescript v6 #9590

Closed
joheredi opened this issue Jun 17, 2020 · 8 comments
Closed

[Keyvault] Regenerate swagger using Autorest Typescript v6 #9590

joheredi opened this issue Jun 17, 2020 · 8 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@joheredi
Copy link
Member

joheredi commented Jun 17, 2020

This issue tracks the work to re-generate the sawgger using the latest version of @autorest/typescript

In order to use the new generator 2 changes need to be done in swagger/readme.md files

v3: true
use-extension:
  "@autorest/typescript": "6.0.0-dev.20200618.1"

Note
The latest @autorest/typescript version can be found here

@joheredi joheredi added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jun 17, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] July milestone Jun 18, 2020
@ramya-rao-a
Copy link
Contributor

@sadasant,

Lets have 3 separate PRs for the 3 Keyvault packages using the same swagger files that were used to generate what is in the master branch. There should be no net functional change for the end user with these changes. The only change would be in the generated client and how the convenience layer talks to the generated client.

@sadasant
Copy link
Contributor

Now that I have a better picture of what's required to update this, I need to go back to the drawing board. There are some updates that are potentially public API changes. I'm asking the feature crew.

@sadasant
Copy link
Contributor

Likely no need for API changes. But more clarity on what properties we’re sending.

@sadasant
Copy link
Contributor

I had to close my latest PR. The latest Autorest & Autorest Typescript forces us to use api-version 7.1. It doesn't allow us to specify api-version 7.0, which is a regression. We'll come back to this issue during the next release cycle.

@sadasant
Copy link
Contributor

Also, for the record:
This made me realize we weren't sending a property in createKey: #11245 (comment)

Which led to this new issue: #11263

@ramya-rao-a ramya-rao-a added this to the [2021] January milestone Dec 23, 2020
@sarangan12
Copy link
Member

The keyvault-keys package migration has been completed in this PR - #13092

@sarangan12
Copy link
Member

The keyvault-secrets package migration has been completed in this PR - #12821

@sarangan12
Copy link
Member

The keyvault-certificates package migration has been completed in this PR - #12820

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

No branches or pull requests

4 participants