[Key Vault Secrets] Generated code update (9726 9069 9590) #9732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadasant
commented
Jun 26, 2020
| const span = this.createSpan("updateSecretProperties", requestOptions); | ||
| const optionalParams: SecretUpdateParameters = { | ||
| contentType: options.contentType, | ||
| tags: options.tags, | ||
| secretAttributes: { | ||
| enabled, | ||
| notBefore, | ||
| expires | ||
| } |
There was a problem hiding this comment.
I find it interesting how different this is from: https://github.com/Azure/azure-sdk-for-js/pull/9727/files#diff-b7f79eb11bce1239d2cc0fea068e4086R606
|
One good thing from this PR: I believe the lack of changes in the One bad thing about this PR: The generated code has naming inconsistencies, and the convenience layer feels like it could have some refactoring. I don't think I have budget for neither of those at the moment though. |
|
Since #9726 is not intended for July, I'll close this PR. It will be easy to re-do this for September. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT:
Based on the latest meeting notes, we won't be releasing any related to 7.2 on July. This PR can wait.
This PR attempts to:
coretogenerated.Use Autorest TypeScript v6.Not anymore!All of this in Key Vault Secrets client ONLY.
IMPORTANT: This requires re-generating some recordings. I'll do that after we merge: #9693
For #9726
For #9069
For #9590Not anymore!