Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Use the swagger generated from the service 7.2-preview #9726

Closed
sadasant opened this issue Jun 26, 2020 · 3 comments · Fixed by #11370
Closed

[Key Vault] Use the swagger generated from the service 7.2-preview #9726

sadasant opened this issue Jun 26, 2020 · 3 comments · Fixed by #11370
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@sadasant
Copy link
Contributor

As the title says.

JSON files come from: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2-preview/

swagger README should look along the lines of:

package-name: "@azure/keyvault-admin"
use-extension:
  "@autorest/typescript": "6.0.0-dev.20200623.2"
azure-arm: false
generate-metadata: false
add-credentials: false
license-header: MICROSOFT_MIT_NO_VERSION
input-file:
  - https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2-preview/rbac.json
source-code-folder-path: ./src/generated

The package.json command should look like:

    "regenerate": "npx autorest swagger/README.md --typescript --version=3.0.6267",

The core folder should be named generated.

@ramya-rao-a
Copy link
Contributor

Please use v5 of the code generator for this task to reduce the amount of code changes this late in the sprint cycle.
We can use v6 as part of #9590

@sadasant
Copy link
Contributor Author

@ramya-rao-a Moved this to September, based on the latest meeting that Heath had. We're only shipping 7.1 stuff in July.

@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jul 20, 2020
@ramya-rao-a ramya-rao-a added the blocking-release Blocks release label Sep 11, 2020
@sadasant
Copy link
Contributor Author

Just to reiterate, for @autorest/typescript v6 and autorest v3 we have this other issue: #9590

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants