Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-bus] Make client validation consistent with other languages #12312

Closed
2 of 7 tasks
richardpark-msft opened this issue Nov 5, 2020 · 0 comments · Fixed by #12490
Closed
2 of 7 tasks

[service-bus] Make client validation consistent with other languages #12312

richardpark-msft opened this issue Nov 5, 2020 · 0 comments · Fixed by #12490
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@richardpark-msft
Copy link
Member

richardpark-msft commented Nov 5, 2020

There are a few areas within the Service Bus package where we do client-side validation. After a review with the other language crews we've come up with the following changes that need to be made:

(using row numbers from our internal onenote):

  • 1. Partition key != session ID: @JoshLove-msft to determine error message by Fri.
  • 2. settle a message twice: "The message has either been deleted or already settled "
  • 3. Settle a message that has been peeked:
    • Check receiver mode first: "The operation not supported in 'ReceiveAndDelete' receive mode."
    • Check lock token next: "This operation is not supported for peeked messages. Only messages received using (methods) in PeekLock mode can be settled."
  • 4. Settle a message that was received in receiveAndDelete mode: "The operation not supported in 'ReceiveAndDelete' receive mode." (should get this for free once (3) is done)
  • 13. peekMessages where count < 0: "maxMessageCount must be 1 or greater"
    - [ ] 14. receiveDeferredMessages with an empty list: "sequenceNumbers cannot be empty"
    - [ ] 16. empty batch send: "A ServiceBusMessageBatch or list of Message must have at least one Message"
  • 18. Renew message lock on message received from session: "Renewing message lock is an invalid operation when working with sessions."
  • 19, 20, 21: SessionId/ReplyToSessionId/MessageId/PartitionKey > 128 characters: " cannot be longer than 128 characters."
@richardpark-msft richardpark-msft added Client This issue points to a problem in the data-plane of the library. Service Bus labels Nov 5, 2020
@richardpark-msft richardpark-msft added this to the [2020] December milestone Nov 5, 2020
@ramya-rao-a ramya-rao-a self-assigned this Nov 5, 2020
@ramya-rao-a ramya-rao-a added the blocking-release Blocks release label Nov 10, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jan 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants