Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Throw when partitionKey is not same as sessionId #12490

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

ramya-rao-a
Copy link
Contributor

This PR adds validation checks for when partitionKey and sessionId are set to different values. Closes #12312

@ramya-rao-a
Copy link
Contributor Author

/azp run js - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

* @throw
*/
export const PartitionKeySessionIdMismatchError =
"The fields 'partitionKey' and 'sessionId' cannot have different values.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add one in a separate PR with the other validation checks I added in previous PRs

Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
@ramya-rao-a
Copy link
Contributor Author

/azp run js - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a ramya-rao-a merged commit ff9d8cd into Azure:master Nov 11, 2020
@ramya-rao-a ramya-rao-a deleted the sb-validateion branch November 11, 2020 23:40
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Feb 18, 2021
[Hub Generated] Review request for Microsoft.ImportExport to add version preview/2021-01-01 (Azure#12490)

* Adds base for updating Microsoft.ImportExport from version stable/2020-08-01 to version 2021-01-01

* Updates readme

* Updates API version in new specs and examples

* making changes to swagger for upgraded version

* prettier fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[service-bus] Make client validation consistent with other languages
2 participants