Unable to use $top with list users

[Stono]

Describe the bug
Hi,
I can't for the life of me get $top working when listing users.

  ): Promise<Array<User>> {
    const client = await this.getClient()
    const options = { $top: '10' }
    const users = odatanextLink
      ? await client.users.listNext(odatanextLink, options)
      : await client.users.list(options)

    if (users.odatanextLink) {
      const aggregatedUsers = runningUserList.concat(users)
      console.log(users.odatanextLink, aggregatedUsers.length)
      return this.users(aggregatedUsers, users.odatanextLink)
    }
    return runningUserList

When i run this code, i always get a page size of 100 regardless what value i set '$top' to. Can you see what i'm doing wrong?

[ramya-rao-a]

Hey @Stono

Can you share which package are you using here? This repo houses multiple packages, and it would help to know which one are you using.

[Stono]

Sorry, @azure/graph specifically GraphRbacManagementClient

[ramya-rao-a]

Thanks @Stono

I don't see $top being a valid option to set in either the list or listNext methods.
This would mean that you can only ever get whatever the service returns being in the next page and not really control the page size.

I may be wrong here...

@joheredi, This package is auto generated using the v4 code gen. Can you share if there is any way to control the page size?

[deyaaeldeen]

@ramya-rao-a Generally, in our core-paging package, we have a byPage method

azure-sdk-for-js/sdk/core/core-paging/types/latest/core-paging.d.ts

Line 32 in 1cdf789

byPage: (settings?: PageSettingsT) => AsyncIterableIterator<PageT>;

which should be part of every paged iterator in our SDK. This method takes settings as input which by default is an object with maxPageSize field that controls the size of the page.

Correct me if I am wrong @joheredi but I think this paging support was recently implemented in the code generator v6 and this package was not generated in a long time.

[ramya-rao-a]

@deyaaeldeen This issue is for the @azure/graph package which uses @azure/ms-rest-js and @azure/ms-rest-azure-js, not any of the newer core packages. So, the above note on core-paging does not apply

[deyaaeldeen]

@Stono I created a fix but I would like to verify that it works for you. Could you please run this to create the patched package locally?
git clone --no-checkout https://github.com/azure/azure-sdk-for-js graphrbac_patched && cd graphrbac_patched && git fetch origin pull/13858/head:pr/13858 && git checkout pr/13858 && git sparse-checkout init --cone && git sparse-checkout set sdk/graphrbac/graph && cd sdk/graphrbac/graph && npm pack

The package will be created in this path: <the path to your current directory before running the command>/graphrbac_patched/sdk/graphrbac/graphazure-graph-5.1.0.tgz. You can then install it using npm install <path to the tgz file> inside your local project.

[Stono]

Hello
Thanks for doing this, but we've moved to the @microsoft/microsoft-graph-client client now (interestingly top doesn't seem to work there either - haha).

[ramya-rao-a]

Thanks for getting back to us on this @Stono

Closing this issue as per #13858 (comment)