Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph RBAC] Regenerate with top param for users op #13858

Closed
wants to merge 2 commits into from

Conversation

deyaaeldeen
Copy link
Member

Regenerate the graph rbac package with the swagger here: Azure/azure-rest-api-specs#13045 (the get users operation gets $top as a parameter) to help fix #13625.

Regeneration command: npx autorest --typescript --typescript-sdks-folder=~/repo --license-header=MICROSOFT_MIT_NO_VERSION ~/azure-rest-api-specs/specification/graphrbac/data-plane/readme.md --use=@microsoft.azure/autorest.typescript@4.4.4.

@jeremymeng
Copy link
Member

The Graph supports the following query options: $filter, $orderby, $expand, $top, and $format. The following query options are not currently supported: $count, $inlinecount, and $skip.

  • What about other listing APIs that also take these parameters?

@ramya-rao-a
Copy link
Contributor

@deyaaeldeen Given that Azure AD Graph API is on its path of being deprecated in favor of the Microsoft Graph API, it is not worth pursuing the fix in this PR.

We can keep Azure/azure-rest-api-specs#13045 open. If the service team agrees to the change and requests an update to the generated package across languages, we can revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use $top with list users
3 participants