Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Array flattening in deserializer loses previously de-serialized attributes #15653

Closed
jeremymeng opened this issue Jun 9, 2021 · 0 comments · Fixed by #15655
Closed

[core] Array flattening in deserializer loses previously de-serialized attributes #15653

jeremymeng opened this issue Jun 9, 2021 · 0 comments · Fixed by #15655
Assignees
@jeremymeng
Labels
Azure.Core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.

Comments

@jeremymeng
Copy link
Member

original issue: Azure/ms-rest-js#450

azure-sdk-for-js/sdk/core/core-http/src/serializer.ts

Lines 939 to 943 in 66c6025

instance = serializer.deserialize(
propertyMapper,
propertyInstance,
propertyObjectName,
options

azure-sdk-for-js/sdk/core/core-client/src/serializer.ts

Lines 965 to 970 in 66c6025

instance = serializer.deserialize(
propertyMapper,
propertyInstance,
propertyObjectName,
options
);

Any previously deseriaized attributes on the instance before the sequence will be lost.
@jeremymeng jeremymeng added Azure.Core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. labels Jun 9, 2021
@jeremymeng jeremymeng self-assigned this Jun 9, 2021
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this issue Jun 9, 2021
@jeremymeng
[core] Copy existing properties when flattening array in deserialization
5c7aa58 
Porting fix from Azure/ms-rest-js#451.

When flattening array, we were assigning directly to the result
instance, thus losing any properties that were deserialized previously
in the loop.  The fix is to copy the existing properties over.

Fixes Azure#15653.
@jeremymeng jeremymeng mentioned this issue Jun 9, 2021
Merged
jeremymeng added a commit that referenced this issue Jun 10, 2021
@jeremymeng
[core] Copy existing properties when flattening array in deserializat…
d79be18 
…ion (#15655)

Porting fix from Azure/ms-rest-js#451.

When flattening array, we were assigning directly to the result
instance, thus losing any properties that were deserialized previously
in the loop.  The fix is to copy the existing properties over.

Fixes #15653.
sadasant pushed a commit to sadasant/azure-sdk-for-js that referenced this issue Jun 21, 2021
@jeremymeng
[core] Copy existing properties when flattening array in deserializat…
e452ec1 
…ion (Azure#15655)

Porting fix from Azure/ms-rest-js#451.

When flattening array, we were assigning directly to the result
instance, thus losing any properties that were deserialized previously
in the loop.  The fix is to copy the existing properties over.

Fixes Azure#15653.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
Azure.Core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Copy existing properties when flattening array in deserialization jeremymeng/azure-sdk-for-js
1 participant
@jeremymeng