Copy attributes back post de-serializing array #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xirzec
reviewed
Jun 7, 2021
lib/serializer.ts
Outdated
| const arrayInstance = serializer.deserialize(propertyMapper, propertyInstance, propertyObjectName); | ||
| // Copy over any properties that have already been added into the instance, where they do | ||
| // not exist on the newly de-serialized array | ||
| Object.entries(instance).forEach(([key, value]) => { |
There was a problem hiding this comment.
nit
Suggested change
| Object.entries(instance).forEach(([key, value]) => { | |
| for (const [key, value] of Object.entries(instance)) { |
|
@jeremymeng, @xirzec Do we have a similar issue in |
I am looking into it. |
jeremymeng
approved these changes
Jun 9, 2021
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Jun 9, 2021
Porting fix from Azure/ms-rest-js#451. When flattening array, we were assigning directly to the result instance, thus losing any properties that were deserialized previously in the loop. The fix is to copy the existing properties over. Fixes Azure#15653.
|
@deyaaeldeen @xirzec are you good with the fix? |
xirzec
approved these changes
Jun 10, 2021
jeremymeng
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jun 10, 2021
…ion (#15655) Porting fix from Azure/ms-rest-js#451. When flattening array, we were assigning directly to the result instance, thus losing any properties that were deserialized previously in the loop. The fix is to copy the existing properties over. Fixes #15653.
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jun 21, 2021
…ion (Azure#15655) Porting fix from Azure/ms-rest-js#451. When flattening array, we were assigning directly to the result instance, thus losing any properties that were deserialized previously in the loop. The fix is to copy the existing properties over. Fixes Azure#15653.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450