Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage]Move the Storage package to use core-rest-pipeline #15813

Closed
sarangan12 opened this issue Jun 17, 2021 · 3 comments · Fixed by #26207
Closed

[Storage]Move the Storage package to use core-rest-pipeline #15813

sarangan12 opened this issue Jun 17, 2021 · 3 comments · Fixed by #26207
Assignees
@EmmaZhu
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@sarangan12
Copy link
Contributor

Please find the details provided in #15594
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 17, 2021
@sarangan12 sarangan12 mentioned this issue Jun 17, 2021
Closed
22 tasks
@jeremymeng
Copy link
Member

Previous manual migration attemp: #13860

  1. The biggest problem is that

We were relying on an issue/behavior (#13159) of URLBuilder. Storage container/blob request urls are either "{url}/{containerName}" or "{url}/{containerName}/{blob}". When URLBuilder does the url parameter replacement, a full url is passed to replace "{url}" and the "{containerName}" or "{containerName}/{blob}" part is dropped.

Now we have different behavior using URL I have to work around it be setting path in operation spec to undefined. The paths have form of "{containerName}" or "{containerName}/{blob}" but they don't seem to get used in Storage (no replacements provided to them via options either). I am not sure whether this is because of the way Storage swagger is written.

  1. need either a copy of isNode, or use from GA version of core-util.
  2. some test failing due to decompression.

@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jun 17, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 17, 2021
@ramya-rao-a ramya-rao-a added the Storage Storage Service (Queues, Blobs, Files) label Jun 18, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] December milestone Jun 18, 2021
@ramya-rao-a ramya-rao-a mentioned this issue Jul 13, 2021
Closed
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Aug 27, 2021
CodeGen from PR 15813 in Azure/azure-rest-api-specs
c736856 
track1 modify network readme.go.md (Azure#15813)
@EmmaZhu EmmaZhu modified the milestones: [2021] December, [2022] March Dec 14, 2021
@sarangan12 sarangan12 mentioned this issue Dec 17, 2021
Merged
@ramya-rao-a ramya-rao-a modified the milestones: [2022] March, [2022] April Feb 9, 2022
@xirzec xirzec modified the milestones: [2022] April, [2022] June May 17, 2022
@xirzec xirzec modified the milestones: [2022] June, [2022] July Jun 13, 2022
@xirzec xirzec modified the milestones: 2022-07, 2022-08 Jul 8, 2022
@xirzec xirzec modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@xirzec xirzec modified the milestones: 2022-09, 2022-12 Nov 1, 2022
@xirzec xirzec modified the milestones: 2022-12, 2023-02 Jan 11, 2023
@xirzec xirzec mentioned this issue Feb 11, 2023
Merged
xirzec added a commit that referenced this issue Mar 1, 2023
@xirzec
[storage-file-datalake] Migrate to core-rest-pipeline (#24835)
83d9b65 
### Packages impacted by this PR

`@azure/storage-file-datalake`

### Issues associated with this PR

#15813

### Describe the problem that is addressed by this PR

This PR migrates storage-file-datalake to the new core pipeline in the
same fashion that storage-blob was recently migrated. There are no
changes to the public surface and existing recorded tests still pass.


### Provide a list of related PRs _(if any)_

#24141
@xirzec xirzec removed this from the 2023-02 milestone Mar 31, 2023
@xirzec xirzec mentioned this issue Jun 5, 2023
Merged
xirzec added a commit that referenced this issue Jun 7, 2023
@xirzec
[storage-file-share] Migrate to core-rest-pipeline (#26102)
e7f9ea3 
### Packages impacted by this PR

`@azure/storage-file-share`

### Issues associated with this PR

#15813

### Describe the problem that is addressed by this PR

This PR migrates storage-file-share to the new core pipeline in the same
way that storage-blob and storage-file-datalake were migrated. There are
no changes to the public surface and existing recorded tests still pass.

### Provide a list of related PRs _(if any)_

#24141, #24835
KarishmaGhiya pushed a commit that referenced this issue Jun 8, 2023
@xirzec @KarishmaGhiya
[storage-file-share] Migrate to core-rest-pipeline (#26102)
44f14a9 
### Packages impacted by this PR

`@azure/storage-file-share`

### Issues associated with this PR

#15813

### Describe the problem that is addressed by this PR

This PR migrates storage-file-share to the new core pipeline in the same
way that storage-blob and storage-file-datalake were migrated. There are
no changes to the public surface and existing recorded tests still pass.

### Provide a list of related PRs _(if any)_

#24141, #24835
minhanh-phan pushed a commit to minhanh-phan/azure-sdk-for-js that referenced this issue Jun 12, 2023
@xirzec @minhanh-phan
[storage-file-share] Migrate to core-rest-pipeline (Azure#26102)
f18de27 
### Packages impacted by this PR

`@azure/storage-file-share`

### Issues associated with this PR

Azure#15813

### Describe the problem that is addressed by this PR

This PR migrates storage-file-share to the new core pipeline in the same
way that storage-blob and storage-file-datalake were migrated. There are
no changes to the public surface and existing recorded tests still pass.

### Provide a list of related PRs _(if any)_

Azure#24141, Azure#24835
@xirzec xirzec mentioned this issue Jun 14, 2023
Merged
xirzec added a commit that referenced this issue Jun 15, 2023
@xirzec
[storage-queue] Migrate to core-rest-pipeline (#26207)
6582843 
### Packages impacted by this PR

`@azure/storage-queue`

### Issues associated with this PR

Fixes #15813
Closes #15594

### Describe the problem that is addressed by this PR

This PR migrates storage-queue to the new core pipeline in the same way
that storage-file-share was migrated. There are no changes to the public
surface and existing recorded tests still pass.

### Provide a list of related PRs _(if any)_

#26102
@MRayermannMSFT
Copy link

🥳 @xirzec et. al.

@xirzec
Copy link
Member

xirzec commented Jun 15, 2023

🥳 @xirzec et. al.

Thanks @MRayermannMSFT! Looking forward to your feedback on the new versions and will be happy to investigate any issues you run into.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EmmaZhu EmmaZhu

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[storage-queue] Migrate to core-rest-pipeline xirzec/azure-sdk-for-js
6 participants
@sarangan12 @xirzec @EmmaZhu @jeremymeng @ramya-rao-a @MRayermannMSFT