-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[engsys] remove openTelemetryCommonJs()
rollup name exports from dev-tool
#17707
Comments
@jeremymeng All the new mgmt plane packages are using core-rest-pipeline now. Can you check if your findings above still apply? |
@ramya-rao-a many packages still contain
|
Looks like apart from the generated mgmt plane packages, the only package using @jeremymeng Can you review the case for synapse-monitoring and then log an issue in the code generator for the required changes? |
Codegen tracking issue: Azure/autorest.typescript#1282 |
openTelemetryCommonJs()
rollup name exportsopenTelemetryCommonJs()
rollup name exports from dev-tool
It is a workaround for packages that uses older version of core-tracing libraries. Now it only applies to two packages. This PR removes the export from `dev-tool` and have copies of the function in the two communication packages' test rollup config instead. Part of Azure#17707
Closing. all remaining open telemetry commonjs workarounds have separate issues to track the removal of them |
The latest opentelemetry/api package has
esm
support so packages depending on the latest version don't need the rollup cjs name exports.all packages using the shared one from dev-tool can safely remove it except one
communication-chat
which indirectly depends on older version of opentelemetry/api fromcommunication-signaling
, which is being updated. We could either wait for a new version ofcommunication-chat
, or remove the shared one and add a copy forcommunication-chat
before it has a new version.generated management packages has a copy of the function
openTelemetryCommonJs()
in rollup.config.js from codegen. We want update code generator to move to latest version ofcore-rest-pipeline
and removeopenTelemetryCommonJs()
The text was updated successfully, but these errors were encountered: