[synapse-monitoring] Fix packaging issues #19864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the path of "module" field is incorrect * the ESM output folder should be `dist-esm` as specified in tsconfig.json While on this I also updated the compilation target to `es6`, and removed the `openTelemetryCommonJs()` that is no longer needed.
jeremymeng
requested review from
deyaaeldeen,
joheredi and
witemple-msft
as code owners
ghost
added
the
jeremymeng
added
the
Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few packaging issues:
dist-esmas specified in tsconfig.jsonWhile on this I also updated the compilation target to
es6, and removed theopenTelemetryCommonJs()that is no longer needed.Checklists
Issues associated with this PR:
#17707
Does this PR needs any fixes in the SDK Generator? (If so, create an Issue in the Autorest/typescript repository and link it here)
No, codegen works expected. This lib is generated + manual work on top of it.
Are there test cases added in this PR?(If not, why?)
packaging issue, not applicable.