Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate communication-common auth policies to Core v2 #20056

Closed
DominikMe opened this issue Jan 25, 2022 · 2 comments
Closed

Migrate communication-common auth policies to Core v2 #20056

DominikMe opened this issue Jan 25, 2022 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Communication

Comments

@DominikMe
Copy link
Member

This is a dependency for #15814, please follow links in the issues to learn about the Core v2 migration effort.

The HMAC credential policy code in the common package needs to be migrated to the new core-rest interfaces. Once that is done, the consumers of ACS HMAC auth need to consume the new pipelines when doing their migration.

These consumers are communication-phone-numbers, communication-identity, communication-network-traversal, communication-sms and communication-short-codes.

@AlonsoMondal is copying and migrating the policies in PR #19043 for now.

This migration should be done inside the communication-common package instead and short-codes should use the common code.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 25, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 25, 2022
@petrsvihlik
Copy link
Contributor

@DominikMe thanks for the heads up. we'll track it and process it soon (ADO ref: https://skype.visualstudio.com/SPOOL/_workitems/edit/2707328)

@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jan 25, 2022
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jan 25, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Sep 22, 2022
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-08-01 (Azure#20056)

* Adds base for updating Microsoft.RecoveryServices from version stable/2022-04-01 to version 2022-08-01

* Updates readme

* Updates API version in new specs and examples

* Update vaults.json

* Update vaults.json

Fixed Prettier error
Copy link

Hi @DominikMe, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Communication
Projects
None yet
Development

No branches or pull requests

4 participants