Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM] Migrate tests to use recorder v2 instead of v1 #23567

Closed
HarshaNalluru opened this issue Oct 20, 2022 · 26 comments
Closed

[ARM] Migrate tests to use recorder v2 instead of v1 #23567

HarshaNalluru opened this issue Oct 20, 2022 · 26 comments
Assignees
@MaryGao @HarshaNalluru @kazrael2119
Labels
Mgmt This issue is related to a management-plane library. test-utils-recorder Label for the issues related to the common recorder
Milestone
2022-12

Comments

@HarshaNalluru
Copy link
Member

We have an ongoing effort of moving recordings for all the tests out of the JS repository to the assets repo.
For that, each of the packages have to be on recorder v2.

"@azure-tools/test-recorder": "^1.0.0" in package.json 

./sdk/**/arm-*/package.json  -> 111 packages

So, 111 arm packages depend on recorder v1.

Most of them look like dummy test files.
image
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 20, 2022
@HarshaNalluru HarshaNalluru added the test-utils-recorder Label for the issues related to the common recorder label Oct 20, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 20, 2022
@HarshaNalluru HarshaNalluru added this to the 2022-12 milestone Oct 20, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.24526887,EngSys:0.14073716,Cognitive - Form Recognizer:0.097520426'

@MaryGao MaryGao added the Mgmt This issue is related to a management-plane library. label Oct 20, 2022
@HarshaNalluru HarshaNalluru self-assigned this Oct 20, 2022
@MaryGao
Copy link
Member

MaryGao commented Oct 26, 2022 •
edited
Loading

@HarshaNalluru I have an rough estimation, there are

  • ~90 sampleTest.ts files which are the dummy files generated by codegen
  • ~40 testing files which are written manually

I think for the generated dummy files we could have a script to exec the steps in upgrading to v2 gist . However for the manual maintained test files we need to fix them one by one.

I could work on the script to upgrade the dummy files and I'd like to confirm with things with you:

  • Do you have a suggested priority or deadline for the issue?
  • Considering we have around 40 files to change manually, could you work with me together to fix them?

@HarshaNalluru
Copy link
Member Author

HarshaNalluru commented Oct 26, 2022 •
edited
Loading

Thanks, @MaryGao, for the estimates.
The GIST looks perfect, we can move forward with the plan.

Do you have a suggested priority or deadline for the issue?

Optimistically, before the end of November, we should finish the migration for all.

Considering we have around 40 files to change manually, could you work with me together to fix them?

For sure, can definitely share the work and fix them.

@MaryGao
Copy link
Member

MaryGao commented Nov 16, 2022

@kazrael2119 Could you share the status of refreshing the package?

@kazrael2119
Copy link
Contributor

kazrael2119 commented Nov 16, 2022 •
edited by MaryGao
Loading

The libs are upgraded to recorder v2 at 11/14:

  • @azure/arm-advisor link

@kazrael2119
Copy link
Contributor

kazrael2119 commented Nov 17, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 11/17:

  • @azure/arm-attestation
  • @azure/arm-azureadexternalidentities
  • @azure/arm-azurestack
  • @azure/arm-azurestackhci
    -link：Recording refresh1 #23867

@kazrael2119
Copy link
Contributor

kazrael2119 commented Nov 18, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 11/18:

@azure/arm-changeanalysis
@azure/arm-changes
link:#23888

@azure/arm-billing
@azure/arm-botservice
link:#23884

@kazrael2119
Copy link
Contributor

The libs are upgraded to recorder v2 at 11/23:

@azure/arm-confluent
@azure/arm-containerregistry
@azure/arm-customerinsights
link:#23905

@azure/arm-deploymentmanager
@azure/arm-desktopvirtualization
@azure/arm-devspaces
@azure/arm-devtestlabs
link:#23937

@azure/arm-dns
@azure/arm-domainservices
@azure/arm-eventhub
link:#23954

@kazrael2119
Copy link
Contributor

The libs are upgraded to recorder v2 at 11/28：

@azure/arm-features
@azure/arm-locks
@azure/arm-policy
@azure/arm-links
@azure/arm-managedapplications
@azure/arm-templatespecs
@azure/arm-resources-subscriptions
link:#23959

@kazrael2119
Copy link
Contributor

kazrael2119 commented Nov 29, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 11/29：

@azure/arm-databox
@azure/arm-databoxedge
@azure/arm-databricks
link:#23917

@azure/arm-datacatalog
@azure/arm-datadog
@azure/arm-datamigration
link:#23929

@azure/arm-frontdoor
@azure/arm-hanaonazure
link:#23961

@kazrael2119
Copy link
Contributor

The libs are upgraded to recorder v2 at 11/30：

@azure/arm-healthbot
@azure/arm-healthcareapis
@azure/arm-hybridcompute
@azure/arm-hybridkubernetes
link:#23999

@kazrael2119
Copy link
Contributor

kazrael2119 commented Dec 2, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 12/02

@azure/arm-iotcentral
@azure/arm-keyvault
@azure/arm-kubernetesconfiguration
link:#24004

@azure/arm-commitmentplans
@azure/arm-webservices
@azure/arm-workspaces
@azure/arm-machinelearning
link:#24006

@azure/arm-machinelearningcompute
@azure/arm-managementgroups
@azure/arm-maps
@azure/arm-mariadb
link:#24038

@azure/arm-operationsmanagement
@azure/arm-peering
@azure/arm-postgresql
@azure/arm-powerbiembedded
link:#24082

@kazrael2119
Copy link
Contributor

The libs are upgraded to recorder v2 at 12/05

@azure/arm-privatedns
@azure/arm-purview
@azure/arm-quota
link:#24089

@kazrael2119
Copy link
Contributor

The libs are upgraded to recorder v2 at 12/06

@azure/arm-mixedreality
@azure/arm-mysql
@azure/arm-notificationhubs
@azure/arm-oep
link:#24072

@kazrael2119
Copy link
Contributor

The libs are upgraded to recorder v2 at 12/09

@azure/arm-commerce:#23902

@HarshaNalluru
Copy link
Member Author

Thanks, @kazrael2119, for the progress. 💚
It's great to see the packages being onboarded to recorder v2.

@kazrael2119
Copy link
Contributor

kazrael2119 commented Dec 12, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 12/12:

@azure/arm-recoveryservicesbackup #24118

@kazrael2119
Copy link
Contributor

kazrael2119 commented Dec 13, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 12/13:

@azure/arm-resourcemover #24155

@azure/arm-datalake #23969

@kazrael2119
Copy link
Contributor

kazrael2119 commented Dec 14, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 12/14

@azure/arm-hardwaresecuritymodules #24008

@azure/arm-redisenterprise
@azure/arm-resourcegraph
@azure/arm-serialconsole
@azure/arm-servicebus #24153

@kazrael2119
Copy link
Contributor

kazrael2119 commented Dec 16, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 12/16

@azure/arm-sql #24198

@azure/arm-timeseriesinsights #24219

@azure/arm-streamanalytics
@azure/arm-videoanalyzer
@azure/arm-visualstudio #24210

@azure/arm-servicefabric
@azure/arm-servicelinker
@azure/arm-storagesync
@azure/arm-storsimple1200series
@azure/arm-storsimple8000series #24196

@kazrael2119
Copy link
Contributor

kazrael2119 commented Dec 20, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 12/20:
@azure/arm-synapse #24212

@azure/arm-search #24182

@azure/arm-cdn #23887

@kazrael2119
Copy link
Contributor

kazrael2119 commented Dec 21, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 12/21:

@azure/arm-appservice-profile-2020-09-01-hybrid
@azure/arm-authorization-profile-2020-09-01-hybrid
@azure/arm-commerce-profile-2020-09-01-hybrid
@azure/arm-compute-profile-2020-09-01-hybrid #24246

@azure/arm-databoxedge-profile-2020-09-01-hybrid
@azure/arm-dns-profile-2020-09-01-hybrid
@azure/arm-eventhub-profile-2020-09-01-hybrid
@azure/arm-iothub-2020-09-01-hybrid #24286

@kazrael2119
Copy link
Contributor

The libs are upgraded to recorder v2 at 12/22:

@azure/arm-locks-profile-2020-09-01-hybrid
@azure/arm-keyvault-profile-2020-09-01-hybrid
@azure/arm-monitor-profile-2020-09-01-hybrid
@azure/arm-mysql-flexible #24302

@kazrael2119
Copy link
Contributor

kazrael2119 commented Dec 23, 2022 •
edited
Loading

The libs are upgraded to recorder v2 at 12/23：

@azure/arm-network-profile-2020-09-01-hybrid
@azure/arm-policy-profile-2020-09-01-hybrid
@azure/arm-postgresql-flexible
@azure/arm-resources-2020-09-01-hybrid
@azure/arm-subscription-2020-09-01-hybrid
@azure/arm-storage-2020-09-01-hybrid #24318

@azure/arm-servicemap #24270

@kazrael2119
Copy link
Contributor

Hi @HarshaNalluru ,all mgmt packages are refreshed ,can we close this issue?

@HarshaNalluru
Copy link
Member Author

Yes, thanks a ton @kazrael2119 🎉

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MaryGao MaryGao

@HarshaNalluru HarshaNalluru

@kazrael2119 kazrael2119

Labels
Mgmt This issue is related to a management-plane library. test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
2022-12
Development

No branches or pull requests
4 participants
@MaryGao @HarshaNalluru @azure-sdk @kazrael2119