[refresh] synapse refresh #24212
Merged
[refresh] synapse refresh #24212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazrael2119
requested review from
witemple-msft,
deyaaeldeen,
ckairen,
jeremymeng,
qiaozha,
dw511214992 and
MaryGao
as code owners
ghost
added
MaryGao
reviewed
Dec 16, 2022
| @@ -0,0 +1,498 @@ | |||
| # client library samples for JavaScript (Beta) | |||
|
|
|||
| These sample programs show how to use the JavaScript client libraries for in some common scenarios. | |||
There was a problem hiding this comment.
I think we need to remove all samples under foler v9-beta
MaryGao
reviewed
Dec 16, 2022
| @@ -941,20 +941,6 @@ export interface RecoverableSqlPoolListResult { | |||
| readonly nextLink?: string; | |||
| } | |||
|
|
|||
| /** A list of the server's dedicated sql minimal tls settings. */ | |||
| export interface DedicatedSQLminimalTlsSettingsListResult { | |||
| /** | |||
There was a problem hiding this comment.
Why are these interfaces removed?
MaryGao
reviewed
Dec 16, 2022
MaryGao
reviewed
Dec 16, 2022
| recorder = record(this, recorderEnvSetup); | ||
| beforeEach(async function(this: Context) { | ||
| recorder = new Recorder(this.currentTest); | ||
| await recorder.start(recorderOptions); |
There was a problem hiding this comment.
Could you add some test cases for this rp?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concern about breaking change