Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdn release #23887

Merged
merged 10 commits into from
Dec 20, 2022
Merged

cdn release #23887

merged 10 commits into from
Dec 20, 2022

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 commented Nov 17, 2022 •
edited by MaryGao
Loading

@ghost ghost added the Mgmt This issue is related to a management-plane library. label Nov 17, 2022
lirenhe
lirenhe reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@lirenhe lirenhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't quite understand the breaking, can we use the same commit of the Swagger for the exsiting SDK instead of the latest one to avoid breaking change?

@kazrael2119 kazrael2119 changed the title cdn refresh cdn release Dec 8, 2022
@MaryGao
Copy link
Member

MaryGao commented Dec 13, 2022 •
edited
Loading

It is that the old commit id does not work so we take the latest one

Don't quite understand the breaking, can we use the same commit of the Swagger for the exsiting SDK instead of the latest one to avoid breaking change?

Because the old commit id does not work so we take the latest one

@lirenhe
Copy link
Member

lirenhe commented Dec 14, 2022 •
edited
Loading

It is that the old commit id does not work so we take the latest one

Don't quite understand the breaking, can we use the same commit of the Swagger for the exsiting SDK instead of the latest one to avoid breaking change?

Because the old commit id does not work so we take the latest one

My understanding is by default we should use the old commit id to avoid breaking change, is it possbile to investigate why the old one does not work instead of using the latest one directly, especially the latest one contains breaking change.

cc @xboxeer , @qiaozha

@MaryGao MaryGao self-requested a review December 16, 2022 07:39
MaryGao
MaryGao reviewed Dec 19, 2022
View reviewed changes
sdk/cdn/arm-cdn/src/operations/customDomains.ts
resourceGroupName,
profileName,
endpointName,
customDomainName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revert these changes

MaryGao
MaryGao reviewed Dec 19, 2022
View reviewed changes
sdk/cdn/arm-cdn/src/operations/customDomains.ts
}

// #endregion

// Operation Specifications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kazrael2119 kazrael2119 requested a review from ckairen as a code owner December 19, 2022 08:11
@MaryGao MaryGao self-requested a review December 20, 2022 07:31
MaryGao
MaryGao approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao merged commit 3e79f2a into Azure:main Dec 20, 2022
@kazrael2119 kazrael2119 mentioned this pull request Dec 20, 2022
Closed
@kazrael2119 kazrael2119 deleted the cdn-refresh branch February 14, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe left review comments

@MaryGao MaryGao MaryGao approved these changes

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@dw511214992 dw511214992 Awaiting requested review from dw511214992

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kazrael2119 @MaryGao @lirenhe @dw511214992 @qiaozha