Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all mgmt test recording files to assets repo #25410

Closed
MaryGao opened this issue Mar 30, 2023 · 8 comments
Closed

Migrate all mgmt test recording files to assets repo #25410

MaryGao opened this issue Mar 30, 2023 · 8 comments
Assignees
Labels
Mgmt This issue is related to a management-plane library.

Comments

@MaryGao
Copy link
Member

MaryGao commented Mar 30, 2023

Migrate all mgmt test recording files to asserts repo.

Follow the wiki: https://github.com/azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/ASSET_SYNC_MIGRATION.md
and the pr: #25350

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 30, 2023
@MaryGao MaryGao added the Mgmt This issue is related to a management-plane library. label Mar 30, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 30, 2023
@MaryGao
Copy link
Member Author

MaryGao commented Apr 3, 2023

/cc @HarshaNalluru FYI - we'll start this work in April sprint.

@kazrael2119
Copy link
Contributor

kazrael2119 commented Apr 4, 2023

Hi @HarshaNalluru, when I tried to run this command in https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/ASSET_SYNC_MIGRATION.md#migration:

npx dev-tool test-proxy migrate --initial-push

I got this error:
image
and in asset.json, tag is empty:
image

could you give some suggestions about that?thanks

@kazrael2119
Copy link
Contributor

@MaryGao
Copy link
Member Author

MaryGao commented Apr 4, 2023

@HarshaNalluru Offline checked with @kazrael2119 it may be caused by the permission issue. Do you know how to get the push permission?

Ziwei tried below command git push origin js/quota/arm-quota_8d54e26105xx and then get the 403 error.

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Apr 11, 2023

@MaryGao was oof last week, getting back now, will take a look and get back.
Will reach out offline

@MaryGao
Copy link
Member Author

MaryGao commented Apr 12, 2023

No worries, Just take your time.

@HarshaNalluru HarshaNalluru changed the title Migrate all mgmt test recording files to asserts repo Migrate all mgmt test recording files to assets repo Apr 21, 2023
MaryGao pushed a commit that referenced this issue Apr 27, 2023
qiaozha pushed a commit that referenced this issue Apr 28, 2023
qiaozha pushed a commit that referenced this issue Apr 28, 2023
@kazrael2119
Copy link
Contributor

kazrael2119 commented Apr 28, 2023

all mgmt recording files have been migrated to asserts repo except these two:
#25656
#25690

@kazrael2119
Copy link
Contributor

all mgmt recording files have been migrated to asserts repo

minhanh-phan pushed a commit to minhanh-phan/azure-sdk-for-js that referenced this issue Jun 12, 2023
minhanh-phan pushed a commit to minhanh-phan/azure-sdk-for-js that referenced this issue Jun 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests

3 participants