Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyvault-keys] Add a test for importKey #5731

Closed
sadasant opened this issue Oct 23, 2019 · 2 comments · Fixed by #6126
Closed

[keyvault-keys] Add a test for importKey #5731

sadasant opened this issue Oct 23, 2019 · 2 comments · Fixed by #6126
Assignees
@sadasant
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2019] December

Comments

@sadasant
Copy link
Contributor

We're currently not testing this.
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Oct 23, 2019
@sadasant sadasant self-assigned this Oct 23, 2019
@bterlson
Copy link
Member

also getDeletedKey.

@bterlson
Copy link
Member

purgeDeletedKey

@AlexGhiondea AlexGhiondea added this to the [2019] December milestone Nov 7, 2019
@sadasant sadasant mentioned this issue Nov 8, 2019
Merged
sadasant added a commit that referenced this issue Nov 11, 2019
@sadasant
[KeyVault-Keys] Missing tests and a tweak on the recordings. (#6126)
8484e25 
Added missing tests for importKey, getDeletedKey and purgeDeletedKey. I also changed some previously unchanged before/after calls to beforeEach and afterEach, since that makes future diffs smaller and future new recordings easier.

The import code comes from: https://github.com/Azure/azure-sdk-for-python/blob/1d42b625af9d66cc94fd87bad383464c0f6ade4c/sdk/keyvault/azure-keyvault-keys/tests/test_key_client.py#L111

Fixes #5731
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2019] December
Development

Successfully merging a pull request may close this issue.

[KeyVault-Keys] Missing tests and a tweak on the recordings. sadasant/azure-sdk-for-js
3 participants
@bterlson @sadasant @AlexGhiondea