[KeyVault-Keys] Missing tests and a tweak on the recordings. #6126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiajt
reviewed
Nov 11, 2019
| @@ -463,7 +463,7 @@ export class KeyClient { | |||
| public async importKey( | |||
| name: string, | |||
| key: JsonWebKey, | |||
| options: ImportKeyOptions | |||
| options?: ImportKeyOptions | |||
There was a problem hiding this comment.
This was originally made required because of aligning with the C# change:
"Remove ImportKey overload that does NOT take ImportKeyOptions"
I'm fine making it optional, but was trying to align with the change request.
There was a problem hiding this comment.
On second thought, everything in ImportKeyOptions is optional, so it doesn't make sense to require this.
sophiajt
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing tests for importKey, getDeletedKey and purgeDeletedKey. I also changed some previously unchanged before/after calls to beforeEach and afterEach, since that makes future diffs smaller and future new recordings easier.
The import code comes from: https://github.com/Azure/azure-sdk-for-python/blob/1d42b625af9d66cc94fd87bad383464c0f6ade4c/sdk/keyvault/azure-keyvault-keys/tests/test_key_client.py#L111
Fixes #5731