-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verifying VS Code debugger with default configuration works on tests in our SDKs #10145
Conversation
I'm curious on why |
The build pipelines run certain npm test scripts and upload the code coverage results. Please ensure that still work. |
So there are two common use cases that I want to confirm still work:
As long as those two cases work this is great! |
d211349
to
2e9dae3
Compare
@jeremymeng I guess it has something to do with source maps. I will do some digging and get back to you. @xirzec So you do the following. Hit CTRL+SHIFT+D to open the debugger panel, click on "show" all automatic debug configurations (if you do not have other debug configs). choose Node.js (Preview) from the dropdown menu, and finally select your favorite npm testing script. Later, you can hit F5 to debug using that same npm script It remembers the automatic config you selected but sometimes it does not if it is the only config you have. Regarding the second point, debugging samples in vscode is already not working currently on master, or does it? |
@jeremymeng yup it is source maps related and is fixed by passing |
78521a5
to
aabe17e
Compare
@@ -7,22 +7,15 @@ | |||
{ | |||
"type": "node", | |||
"request": "launch", | |||
"name": "Current TS File", | |||
"args": ["${fileBasename}"], | |||
"runtimeArgs": ["--nolazy", "-r", "ts-node/register"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we pass those arguments?
…iguration feature in vscode
…th vscode debugger
aabe17e
to
3b4af46
Compare
@ramya-rao-a in our offline discussion, there were two follow-up items I will look at them later and I believe they are not blocking merging this PR. Does the PR look good to you? |
This has been sitting idle for too long, would you guys take a look? cc @willmtemple, @jeremymeng, @richardpark-msft, @XiaoningLiu @HarshaNalluru |
/azp run js - storage-queue - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
launch.json
files that mostly duplicate testing commands that already exist as npm scripts.nyc
calls to its own coverage scripts inpackage.json
files when it gets in the way of the debugger (when mocha usests-node
).See https://code.visualstudio.com/updates/v1_45#_automatic-debug-configurations for release notes on the vs code debugger with default configuration.