Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] formatting #10265

Merged
merged 1 commit into from
Jul 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions sdk/keyvault/keyvault-certificates/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,7 @@ export class CertificateClient {
};

const pipeline = createPipelineFromOptions(internalPipelineOptions, authPolicy);
this.client = new KeyVaultClient(
pipelineOptions.apiVersion || LATEST_API_VERSION,
pipeline
);
this.client = new KeyVaultClient(pipelineOptions.apiVersion || LATEST_API_VERSION, pipeline);
}

private async *listPropertiesOfCertificatesPage(
Expand Down Expand Up @@ -1437,15 +1434,10 @@ export class CertificateClient {
let result: UpdateCertificateResponse;

try {
result = await this.client.updateCertificate(
this.vaultUrl,
certificateName,
version,
{
...this.setParentSpan(span, requestOptions),
certificateAttributes: toCoreAttributes(options)
}
);
result = await this.client.updateCertificate(this.vaultUrl, certificateName, version, {
...this.setParentSpan(span, requestOptions),
certificateAttributes: toCoreAttributes(options)
});
} finally {
span.end();
}
Expand Down
24 changes: 20 additions & 4 deletions sdk/keyvault/keyvault-certificates/test/public/list.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ describe("Certificates client - list certificates in various ways", () => {
const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
const certificateNames = [`${certificateName}0`, `${certificateName}1`];
for (const name of certificateNames) {
const createPoller = await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
const createPoller = await client.beginCreateCertificate(
name,
basicCertificatePolicy,
testPollerProperties
);
await createPoller.pollUntilDone();
}

Expand All @@ -92,7 +96,11 @@ describe("Certificates client - list certificates in various ways", () => {
const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
const certificateNames = [`${certificateName}0`, `${certificateName}1`];
for (const name of certificateNames) {
const createPoller = await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
const createPoller = await client.beginCreateCertificate(
name,
basicCertificatePolicy,
testPollerProperties
);
await createPoller.pollUntilDone();
}
for (const name of certificateNames) {
Expand All @@ -118,7 +126,11 @@ describe("Certificates client - list certificates in various ways", () => {
const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
const certificateNames = [`${certificateName}0`, `${certificateName}1`];
for (const name of certificateNames) {
const createPoller = await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
const createPoller = await client.beginCreateCertificate(
name,
basicCertificatePolicy,
testPollerProperties
);
await createPoller.pollUntilDone();
}
let found = 0;
Expand Down Expand Up @@ -151,7 +163,11 @@ describe("Certificates client - list certificates in various ways", () => {
const certificateName = testClient.formatName(`${prefix}-${this!.test!.title}-${suffix}`);
const certificateNames = [`${certificateName}0`, `${certificateName}1`];
for (const name of certificateNames) {
const createPoller = await client.beginCreateCertificate(name, basicCertificatePolicy, testPollerProperties);
const createPoller = await client.beginCreateCertificate(
name,
basicCertificatePolicy,
testPollerProperties
);
await createPoller.pollUntilDone();
}
for (const name of certificateNames) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,4 @@ describe("Certificates client - lro - delete", () => {

await testClient.purgeCertificate(certificateName);
});

});
5 changes: 1 addition & 4 deletions sdk/keyvault/keyvault-keys/src/cryptographyClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -709,10 +709,7 @@ export class CryptographyClient {
};

const pipeline = createPipelineFromOptions(internalPipelineOptions, authPolicy);
this.client = new KeyVaultClient(
pipelineOptions.apiVersion || LATEST_API_VERSION,
pipeline
);
this.client = new KeyVaultClient(pipelineOptions.apiVersion || LATEST_API_VERSION, pipeline);

let parsed;
if (typeof key === "string") {
Expand Down
5 changes: 1 addition & 4 deletions sdk/keyvault/keyvault-keys/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,7 @@ export class KeyClient {
};

const pipeline = createPipelineFromOptions(internalPipelineOptions, authPolicy);
this.client = new KeyVaultClient(
pipelineOptions.apiVersion || LATEST_API_VERSION,
pipeline
);
this.client = new KeyVaultClient(pipelineOptions.apiVersion || LATEST_API_VERSION, pipeline);
}

/**
Expand Down
5 changes: 1 addition & 4 deletions sdk/keyvault/keyvault-secrets/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,7 @@ export class SecretClient {
};

const pipeline = createPipelineFromOptions(internalPipelineOptions, authPolicy);
this.client = new KeyVaultClient(
pipelineOptions.apiVersion || LATEST_API_VERSION,
pipeline
);
this.client = new KeyVaultClient(pipelineOptions.apiVersion || LATEST_API_VERSION, pipeline);
}

/**
Expand Down