[Key Vault] formatting #10265
Merged
[Key Vault] formatting #10265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
bterlson,
sophiajt,
sadasant and
xirzec
as code owners
ghost
added
the
ramya-rao-a
suggested changes
Jul 26, 2020
There was a problem hiding this comment.
In the Key Vault packages, the generated code lives in the core folder.
As mentioned in #10272 (review), we should not be formatting the generated code.
Also, consider waiting for #10280 to be merged first where we are renaming core to generated to be consistent with other Track 2 packages in the repo
|
Okay, let's wait for #10280 to be merged. |
deyaaeldeen
force-pushed
the
format-keyvault
branch
from
a92ac06 to
a0fe8aa
Compare
|
@ramya-rao-a I rebased this on the renaming work. |
ramya-rao-a
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of running
rush format.