[Key Vault] Renamed the core folder as generated #10280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ramya-rao-a
reviewed
Jul 25, 2020
| @@ -1,2 +1,2 @@ | |||
| # Ignoring the core files since they're auto-generated. Eventually, the auto-generated code will be on par with our current eslint rules, but in the mean time we should ignore them. | |||
| src/core | |||
| src/generated | |||
There was a problem hiding this comment.
Do we need the .eslintignore file anymore since folders with the name generated are ignored out of the box by our eslint plugin?
There was a problem hiding this comment.
Yes! you're right. Thank you
ramya-rao-a
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the folder
coreasgeneratedon Key Vault Keys, Secrets and Certificates.Fixes #9069